-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DomainMapping CRD and type #9714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9714 +/- ##
=========================================
Coverage ? 87.98%
=========================================
Files ? 179
Lines ? 8455
Branches ? 0
=========================================
Hits ? 7439
Misses ? 772
Partials ? 244
Continue to review full report at Codecov.
|
006894f
to
3fad4d4
Compare
This generally LGTM. You plan to add Validate/Default (and wire into webhook) in a follow-on? |
Yep, added that to the plan of attack in the tracking issue @mattmoor, just trying to keep each PR reasonably small |
/lgtm 🎉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First part of #9713.
Adds a DomainMapping CRD in config/domain-mapping and a new corresponding type in a resurrected apis/serving/v1alpha1 package, and runs code-gen.
/assign @mattmoor @dprotaso