Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cgr.dev/chainguard/static:latest which is nonroot #15310

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 6, 2024

cgr.dev has been around for a while now so the concerns I had in knative/community#1165 are sorta alleviated since it's not backed by Github registry anymore ;)

Probably good to switch serving over to it (it's ko's default image)

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto June 6, 2024 16:34
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@dprotaso
Copy link
Member Author

dprotaso commented Jun 6, 2024

cc @imjasonh

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
Copy link

knative-prow bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 09b4cd3 into knative:main Jun 6, 2024
62 checks passed
@dprotaso dprotaso deleted the use-chainguard-image branch July 24, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants