Fix e2e script to disable cors policy for Contour tests

[izabelacg]

Proposed Changes

• modify e2e-tests script to disable CORS feature by removing the config field instead of setting it to an empty string

Context

Previously, setting the config field to an empty string resulted in parsing errors, leading to net-contour-controller pods entering an error state and causing subsequent tests to fail. This other PR is blocked on this change due to test failures: #15204

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (a0a1ac7) to head (6439d2c).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15235   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files         218      218           
  Lines       13473    13473           
=======================================
  Hits        11420    11420           
+ Misses       1687     1686    -1     
- Partials      366      367    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[izabelacg]

/test contour-latest_serving_main

[izabelacg]

/retest certmanager-integration-tests_serving_main contour-latest_serving_main

[knative-prow]

@izabelacg: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test build-tests
• /test certmanager-integration-tests
• /test contour-latest
• /test contour-tls
• /test gateway-api-latest
• /test istio-latest-no-mesh
• /test istio-latest-no-mesh-tls
• /test kourier-stable
• /test kourier-stable-tls
• /test unit-tests
• /test upgrade-tests

The following commands are available to trigger optional jobs:

• /test gateway-api-latest-and-contour
• /test https
• /test istio-latest-mesh
• /test istio-latest-mesh-short
• /test istio-latest-mesh-tls
• /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

• build-tests_serving_main
• certmanager-integration-tests_serving_main
• istio-latest-no-mesh-tls_serving_main
• istio-latest-no-mesh_serving_main
• unit-tests_serving_main
• upgrade-tests_serving_main

In response to this:

/retest certmanager-integration-tests_serving_main contour-latest_serving_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[izabelacg]

/retest

[dprotaso]

cert manager is flakey ignore it - #15236

made it optional here: knative/infra#442

[izabelacg]

cert manager is flakey ignore it - #15236

Ok, Thanks for letting me know!

How about the code style check for shell, is it a new check? I'm wondering because is complaining about parts I didn't touch in the script

[dprotaso]

/lgtm
/approve
/override style / suggester / shell"

[knative-prow]

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• /
• shell
• style
• suggester

Only the following failed contexts/checkruns were expected:

• EasyCLA
• build-tests_serving_main
• certmanager-integration-tests_serving_main
• contour-latest_serving_main
• istio-latest-no-mesh-tls_serving_main
• istio-latest-no-mesh_serving_main
• style / Golang
• style / suggester / github_actions
• style / suggester / shell
• style / suggester / yaml
• tide
• unit-tests_serving_main
• upgrade-tests_serving_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/lgtm
/approve
/override style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/override "style / suggester / shell"

[knative-prow]

@dprotaso: Overrode contexts on behalf of dprotaso: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[izabelacg]

@dprotaso I wonder if this also needs to be cherry-picked to release-1.14... or it doesn't matter since it just to fix a test script?

[dprotaso]

Going to merge this so I can merge the test deletion
/cherry-pick release-1.14

[knative-prow-robot]

@dprotaso: #15235 failed to apply on top of branch "release-1.14":

Applying: fix command to disable cors policy for Contour tests
Using index info to reconstruct a base tree...
M	test/e2e-tests.sh
Falling back to patching base and 3-way merge...
Auto-merging test/e2e-tests.sh
CONFLICT (content): Merge conflict in test/e2e-tests.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix command to disable cors policy for Contour tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Going to merge this so I can merge the test deletion
/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.