Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use annotation helpers #12307

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 17, 2021

  • bump knative.dev/networking
  • Use annotation helper functions

Part of #12103

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 17, 2021
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers labels Nov 17, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #12307 (58e6c4a) into main (deb8a0b) will decrease coverage by 0.02%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12307      +/-   ##
==========================================
- Coverage   87.49%   87.47%   -0.03%     
==========================================
  Files         195      195              
  Lines        9591     9591              
==========================================
- Hits         8392     8390       -2     
- Misses        920      921       +1     
- Partials      279      280       +1     
Impacted Files Coverage Δ
pkg/reconciler/nscert/nscert.go 69.87% <0.00%> (ø)
pkg/reconciler/route/route.go 78.40% <66.66%> (ø)
pkg/reconciler/route/resources/ingress.go 93.06% <87.50%> (ø)
pkg/reconciler/domainmapping/reconciler.go 92.10% <100.00%> (ø)
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb8a0b...58e6c4a. Read the comment docs.

@nader-ziada
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2021
We're going to introduce kebab-casing but we still want to support
the old format.
@dprotaso dprotaso force-pushed the use-annotation-helpers branch from b88e9b1 to 58e6c4a Compare November 17, 2021 17:26
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2021
@nader-ziada
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2021
@dprotaso
Copy link
Member Author

/retest

@knative-prow-robot knative-prow-robot merged commit 0761bf7 into knative:main Nov 17, 2021
@dprotaso dprotaso deleted the use-annotation-helpers branch November 18, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants