Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DomainMapping conformance test to check DomainClaims #10093

Merged

Conversation

julz
Copy link
Member

@julz julz commented Nov 11, 2020

Part of #9713.

Extends the DomainMapping conformance test to validate that colliding DomainMappings work correctly.

/assign @mattmoor

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #10093 (4339aac) into master (db4879e) will decrease coverage by 0.07%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10093      +/-   ##
==========================================
- Coverage   88.01%   87.94%   -0.08%     
==========================================
  Files         185      185              
  Lines        8686     8708      +22     
==========================================
+ Hits         7645     7658      +13     
- Misses        793      798       +5     
- Partials      248      252       +4     
Impacted Files Coverage Δ
pkg/reconciler/revision/revision.go 87.09% <66.66%> (-2.38%) ⬇️
pkg/reconciler/route/traffic/rollout.go 100.00% <100.00%> (ø)
pkg/reconciler/configuration/configuration.go 85.93% <0.00%> (-2.35%) ⬇️
pkg/reconciler/autoscaling/kpa/scaler.go 88.57% <0.00%> (-1.43%) ⬇️
pkg/activator/net/revision_backends.go 90.49% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4879e...f78e9bf. Read the comment docs.

@mattmoor
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: julz, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@knative-prow-robot knative-prow-robot merged commit 799cd1b into knative:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants