Fix the errors during image resolutions. #10071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those contain URLs and they contain `%` sequences which screw up errors and we get logs like ``` Reason=ContainerMissing Message="Unable to fetch image \"gcr.io/dm-vagababov/helloworld:latest\": failed to resolve image to digest: GET https://gcr.io/v2/token?scope=repository%!!(MISSING)A(MISSING)dm-vagababov%!!(MISSING)F(MISSING)helloworld%!!(MISSING)A(MISSING)pull&service=gcr.io: unsupported status code 429; body: Quota Exceeded." ``` Not cool. Change-Id: I616c1388c6292538e4dc93ca91c9bb451a32be42
knative-prow-robot
added
the
size/S
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #10071 +/- ##
==========================================
- Coverage 87.99% 87.94% -0.05%
==========================================
Files 185 185
Lines 8686 8686
==========================================
- Hits 7643 7639 -4
- Misses 794 798 +4
Partials 249 249
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those contain URLs and they contain
%sequences which screw uperrors and we get logs like
Not cool.
In general, we might want a more holistic, approach, but I'd like this to be in the release tomorrow.
/assign @jonjohnsonjr mattmoor @dprotaso