Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallowing LifeCycle hooks for user container #687

Closed
tcnghia opened this issue Apr 18, 2018 · 2 comments
Closed

Disallowing LifeCycle hooks for user container #687

tcnghia opened this issue Apr 18, 2018 · 2 comments
Assignees
@tanzeeb @bsnchan
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.

Comments

@tcnghia
Copy link
Contributor

tcnghia commented Apr 18, 2018

/area API
/kind dev
/assign @tcnghia

Expected Behavior

We are going to automatically specifying LifeCycle hooks for users in order to ensure a smooth autoscaling experience. It will be more complicated if users are also allowed to specify their LifeCycle hooks. We may want to disallow user LifeCycle hooks in order to keep a simple/easy user experience. If later they have use cases that need it we can consider adding back the support easily -- it won't be as easy the other direction.

Actual Behavior

LifeCycle hooks are allowed today.
@google-prow-robot google-prow-robot added area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding. labels Apr 18, 2018
@tcnghia tcnghia mentioned this issue Apr 18, 2018
Merged
@tcnghia tcnghia removed their assignment Apr 18, 2018
@bsnchan
Copy link
Contributor

bsnchan commented Jun 21, 2018

/assign @tanzeeb @bsnchan

@bsnchan bsnchan mentioned this issue Jun 21, 2018
Merged
google-prow-robot pushed a commit that referenced this issue Jun 25, 2018
@bsnchan @tanzeeb @google-prow-robot
Disallow lifecycle hooks for user containers (#1314)
fc0f92f 
[#687](#687)

Co-authored-by: Tanzeeb Khalili <[email protected]>
@joshua-smith4
Copy link

@tcnghia Having disabled lifecycle hooks, does knative serving expose some other API that allows pods to perform cleanup before being terminated?

ReToCode pushed a commit to ReToCode/serving that referenced this issue Apr 29, 2024
@skonto
allign build image with Eventing (knative#687)
8e2c6da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanzeeb tanzeeb

@bsnchan bsnchan

Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tanzeeb @tcnghia @bsnchan @joshua-smith4 @google-prow-robot