-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new Istio routerule causes small window of 503s #348
Comments
I improved the monitoring of status changes with
I added
to both configuration.yaml and updated_configuration.yaml. However, I continue to see transitions to HTTP 503 when I switch back and forth between
@mattmoor Is there anything I miss? Otherwise I suppose there is more than a missing readiness probe at work. I'll dig a bit in the code if I can figure out what might be going on. |
That's be great. Adding @vaikas-google @ian-mi in case they have any ideas what might be causing this. |
Could this simple be an Istio bug, i.e. https://docs.google.com/document/d/1UXJIqfUGkZlw1aZYSkQDYkq1TnYbOaEkohtoTS2mz1g/edit#heading=h.x9snb54sjlu9 In any case I will submit a PR adding readiness probes. |
I think that's most likely |
Looks like |
Make these tweaks to the conformance tests: * Move namespace creation to test fixture setup (it's super slow and it was leaving the namespace around as a side effect of the test) * Support the case where a cluster is configured to use a resolvable domain, in which case we don't need to get the IP of the ingress and spoof the host (see #443 re. adding docs for how to set this up in a cluster) * Remove readiness probe from container; this wasn't accomplishing what it was intended to b/c of #348 anyway Also tried to make the conformance test docs more succinct.
/assign @tcnghia |
This is checked in envoyproxy/envoy#2774 to fix envoyproxy/envoy#1930 |
Even if when we change the helloworld example and only route traffic after the new revision is already created for a while, we are still hitting the same 503s. |
I tested with Istio 7.0.1 which has envoyproxy/envoy#2774 but the issue isn't fixed. I've sent the relevant log files to Istio team for investigation. |
I opened istio/istio#5204 , since issue doesn't seem to be fixed in 0.7.1. |
Reopen to track Istio issue. |
This is now fixed. |
Steps:
bazel run sample/helloworld:everything.create
while true; do curl -is --header 'Host:demo.myhost.net' -w "%{http_code}\n" -o /dev/null http://${SERVICE_IP}; done | grep 503
bazel run sample/helloworld:updated_everything.apply
Expected:
App stays available, i.e. command from 3. stays quiet
Actual:
App is partially unavailable.
We should add a readiness check to the configuration.
The text was updated successfully, but these errors were encountered: