Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] [CVE-2023-44487] Disable http2 for webhooks #2876

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #2871

Due to CVE-2023-44487 webhooks will use http1 by default, until the issue is fixed properly.

@knative-prow knative-prow bot requested review from krsna-m and ReToCode October 23, 2023 14:39
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d6ab729) 81.88% compared to head (ea1ca18) 81.86%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #2876      +/-   ##
================================================
- Coverage         81.88%   81.86%   -0.02%     
================================================
  Files               167      167              
  Lines             10225    10231       +6     
================================================
+ Hits               8373     8376       +3     
- Misses             1606     1608       +2     
- Partials            246      247       +1     
Files Coverage Δ
webhook/webhook.go 82.27% <50.00%> (-1.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krsna-m
Copy link
Contributor

krsna-m commented Oct 23, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Oct 23, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow knative-prow bot merged commit 29775d7 into knative:release-1.12 Oct 23, 2023
18 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants