adds WithNamespace ability to contexts

[gab-satchi]

Changes

• 🐛 Fixes issue where namespace can be misrepresented in the context. Depending on the client, namespace may not be present in the metadata. With these changes, we attach the namespace directly from the incoming request.

/kind bug

Fixes part of the issue raised in knative/eventing: #4514

Release Note

Docs

[knative-prow-robot]

Welcome @gab-satchi! It looks like this is your first PR to knative/pkg 🎉

[knative-prow-robot]

Hi @gab-satchi. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gab-satchi
To complete the pull request process, please assign mattmoor after the PR has been reviewed.
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• apis/OWNERS
• webhook/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gab-satchi]

I didn't modify one location where the parentMeta is still used: in knative_reference. I'm unsure where else this reference may be getting used and whether it should also be modified in this PR.

[dprotaso]

Looking at the original issue - is this not a k8s bug? I'd expected namespaced resources hitting the webhook to have valid metadata

[dprotaso]

/hold

cc @shinigambit looks like there's an issue with the merge upstream step in the action for non-members of the org?

[codecov]

Codecov Report

Merging #2390 (c0eba4e) into main (3f86f59) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
+ Coverage   63.30%   63.32%   +0.02%     
==========================================
  Files         226      226              
  Lines        9786     9792       +6     
==========================================
+ Hits         6195     6201       +6     
  Misses       3311     3311              
  Partials      280      280              

Impacted Files	Coverage Δ
apis/contexts.go	100.00% <100.00%> (ø)
webhook/resourcesemantics/defaulting/defaulting.go	79.75% <100.00%> (+0.12%)	⬆️
...n/cmd/injection-gen/generators/filtered_factory.go	0.00% <0.00%> (ø)
apis/duck/v1/source_types.go	45.28% <0.00%> (+1.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f1852...c0eba4e. Read the comment docs.

[dprotaso]

/ok-to-test

[pseudorandoom]

I know it's not ideal but while I find the source of the problem I think a rebase against main could make the merge a fast forward and unblock this PR @gab-satchi @dprotaso

[gab-satchi]

Looking at the original issue - is this not a k8s bug? I'd expected namespaced resources hitting the webhook to have valid metadata

Yeah I do think it's better solved in k8s. I'll investigate there

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.