kmap

[dprotaso]

• move some functional map operations to it's own package kmap
• include a new accessor helper for migrating key names
• use kmap methods in various knative.dev/pkg subpackages
• add deprecation notices

This PR has two purposes:

• It sets up the configmap.Parse methods to be moved here
  • queue-proxy is huge serving#9957
• The accessor struct will help us manage multiple annotation keys
  • Inconsistent label/annotations names should follow K8s name conventions (aka. kebab-case) serving#12103

It's important that this package has no external dependencies (especially k8s) to help with queue proxy size issues

[codecov]

Codecov Report

Merging #2354 (0743cb6) into main (5708c4c) will increase coverage by 0.05%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #2354      +/-   ##
==========================================
+ Coverage   63.55%   63.60%   +0.05%     
==========================================
  Files         227      228       +1     
  Lines        9834     9851      +17     
==========================================
+ Hits         6250     6266      +16     
- Misses       3307     3309       +2     
+ Partials      277      276       -1     

Impacted Files	Coverage Δ
kmap/lookup.go	75.00% <75.00%> (ø)
apis/duck/v1/status_types.go	100.00% <100.00%> (ø)
apis/duck/v1beta1/status_types.go	100.00% <100.00%> (ø)
kmap/map.go	100.00% <100.00%> (ø)
reconciler/retry.go	100.00% <0.00%> (ø)
test/gcs/mock/mock.go	91.39% <0.00%> (+1.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5708c4c...0743cb6. Read the comment docs.

[mattmoor]

Generally LGTM.

[dprotaso]

/hold going to update some godoc

unit test failure is some other flake

[dprotaso]

/hold cancel

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso,mattmoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment