Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the defaulting for the leader election config map #1182

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Fix the defaulting for the leader election config map #1182

merged 6 commits into from
Mar 31, 2020

Conversation

vagababov
Copy link
Contributor

  • Add defaulting for all but the component, which are system dependent
  • Improve test coverage
  • Clean up formatting
  • Other test changes

/assign mattmoor @pmorie

@pmorie , Paul do you have a bug for this cleanup?

@vagababov
update go-cmpt to work with 1.14.
7c0f63a 
Mostly to fix google/go-cmp#167, but we also pinned at some
random commit, rather than at a release version.
@vagababov
add new pkg
b93314c
@vagababov
Make sure we use same versions in pkg and serving
484846e
@vagababov
Fix the defaulting for the leader election cm
a3e4599 
This was missing, but now we can provide the default values.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 31, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2020
@vagababov vagababov mentioned this pull request Mar 31, 2020
Merged
mattmoor
mattmoor reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Hold because this seems to contain your yaml change too, which seemed odd to me.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 31, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 31, 2020
@vagababov
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
leaderelection/config.go 61.8% 68.8% 7.0

@vagababov
Copy link
Contributor Author

Rebased :-) needs re-LGTM :)

mattmoor
mattmoor reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@knative-prow-robot knative-prow-robot merged commit 59d2b06 into knative:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@pmorie pmorie

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vagababov @knative-prow-robot @knative-metrics-robot @mattmoor @pmorie @googlebot