Add Namespace field to ClusterDomainClaim #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field has two purposes: - It replaces the ownerReference for ensuring that only one DomainMapping can use a ClusterDomainClaim at a time. This avoids a cross-namespace ownerReference, which isn't supported. - It allows Cluster Operators to delegate a particular domain name to a namespace, allowing that namespace to create DomainMappings with a particular name (and preventing other namespaces squatting or intercepting the name).
knative-prow-robot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 38 38
Lines 815 815
=======================================
Hits 775 775
Misses 29 29
Partials 11 11 Continue to review full report at Codecov.
|
mattmoor
reviewed
Jan 6, 2021
Comment on lines
+65
to
+67
| // Namespace is the namespace which is allowed to create a DomainMapping | ||
| // using this ClusterDomainClaim's name. | ||
| Namespace string `json:"namespace"` |
There was a problem hiding this comment.
We should think about requiring this next release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Spec.NamespacetoClusterDomainClaim.This field has two purposes:
DomainMapping can use a ClusterDomainClaim at a time. This avoids
using cross-namespace ownerReferences, which aren't supported.
namespace, allowing that namespace (and no other) to create DomainMappings
with a particular name (thereby preventing other namespaces squatting on or
intercepting the name).
/kind enhancement
First part of knative/serving#10477 (and also to enable multi-tenant use of DomainMapping, see knative/serving#9713).
Release Note
/assign @mattmoor @tcnghia