feat: specify create time for image built with buildpacks

[cuichenli]

Changes

Currently the image built with func build command all says the image was built 42 years ago. Although it was treated as a feature of buildpacks (in buildpacks/pack#931 (comment)), they have fixed this feature recently in buildpacks/imgutil#138 hence I think it is worth to change the behavior here as well.

/kind enhancement

Note: I am new to the func project and this change may be inappropriate, feel free to reject it. Thanks

[knative-prow]

Welcome @cuichenli! It looks like this is your first PR to knative/func 🎉

[matejvasek]

I think we can have this but I would prefer having this behind some config flag in ~/.config/func/config.yaml.

[cuichenli]

yeah, definitely it would be great to make it configurable. if the owners are ok with this, i will try to implement it.

[codecov]

Codecov Report

Patch coverage: 88.88% and project coverage change: +13.31 🎉

Comparison is base (88b3634) 49.81% compared to head (8db2466) 63.12%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1685       +/-   ##
===========================================
+ Coverage   49.81%   63.12%   +13.31%     
===========================================
  Files          81       93       +12     
  Lines       11148    11989      +841     
===========================================
+ Hits         5553     7568     +2015     
+ Misses       5111     3735     -1376     
- Partials      484      686      +202     

Flag	Coverage Δ
e2e-test	38.94% <88.88%> (?)
e2e-test-oncluster	34.81% <80.55%> (?)
e2e-test-oncluster-runtime	29.64% <80.55%> (?)
e2e-test-runtime-go	28.34% <80.55%> (?)
e2e-test-runtime-node	29.48% <80.55%> (?)
e2e-test-runtime-python	29.48% <80.55%> (?)
e2e-test-runtime-quarkus	29.61% <80.55%> (?)
e2e-test-runtime-springboot	28.47% <80.55%> (?)
e2e-test-runtime-typescript	29.61% <80.55%> (?)
integration-tests	50.05% <77.77%> (?)
unit-tests-macos-latest	48.87% <77.77%> (?)
unit-tests-ubuntu-latest	49.81% <77.77%> (?)
unit-tests-windows-latest	48.95% <77.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/builders/buildpacks/builder.go	65.81% <50.00%> (+18.10%)	⬆️
cmd/build.go	72.57% <100.00%> (+0.59%)	⬆️
cmd/deploy.go	75.80% <100.00%> (+0.86%)	⬆️

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[matejvasek]

@lance @zroubalik wdyt?

[lance]

@lance @zroubalik wdyt?

I agree behind a config flag would be nice

[lkingland]

Perhaps a Builder option WithTimestamp(bool) which would be set when the builder is created in cmd/build.go and cmd/deploy.go, based on the value of a flag --build-timestamp?

[cuichenli]

i have updated accordingly, please let me know if i missed anything. thanks!

[matejvasek]

@cuichenli you need to fix one linter error.

[cuichenli]

i (think) i have fixed it in the latest commit, can you trigger the build again? thanks

[lance]

/lgtm

[lkingland]

Looks really good. Thanks @cuichenli

I re-ran the failed tests. They've been flaky lately

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cuichenli, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment