Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3935: Moving tag resolution docs to developer guide #3970

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jul 7, 2021

Partial fix for #3935 , related to #3710

Proposed Changes

  • Move and clean up tag resolution docs
  • Fixed link and other minor fixes in Operator docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2021
@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: 509cb49

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60e71967bf25f50007eabe5e

😎 Browse the preview: https://deploy-preview-3970--knative.netlify.app/development/admin/install/operator/configuring-serving-cr

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2021
@netlify
Copy link

netlify bot commented Jul 7, 2021

✔️ Deploy Preview for dev-knative ready!

🔨 Explore the source changes: 76ef4c5

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60e61a3b999dc9000770abb6

😎 Browse the preview: https://deploy-preview-3970--dev-knative.netlify.app/development/admin/install/operator/configuring-serving-cr

If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always
includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is 0.16.x, the
earliest version of Knative Serving available through the Operator is 0.14.0.
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0.
Copy link
Contributor

@RichardJJG RichardJJG Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0.
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator does nothing.
The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thought about doing this but wasn't sure whether to split it. Thanks.

@abrennan89 abrennan89 added this to the v0.25.0 milestone Jul 8, 2021
Copy link
Contributor

@RichardJJG RichardJJG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abrennan89, all looks good.

Should the tag-resolution doc have procedures instead of summaries of what the reader can do, though? Either way, I'd be okay with /lgtm at present. I suspect procedures would be better, but they could be tackled in a separate issue if this content is urgent.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89, RichardJJG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7a91394 into knative:mkdocs Jul 8, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick release-0.24

@knative-prow-robot
Copy link
Contributor

@abrennan89: new pull request created: #3981

In response to this:

/cherrypick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89
Copy link
Contributor Author

Thanks, @abrennan89, all looks good.

Should the tag-resolution doc have procedures instead of summaries of what the reader can do, though? Either way, I'd be okay with /lgtm at present. I suspect procedures would be better, but they could be tackled in a separate issue if this content is urgent.

Yeah probably, I'll leave you to open an issue for this though if you think it's worth doing since it's not really part of the scope here for just moving docs.

snneji pushed a commit to snneji/docs that referenced this pull request Jul 9, 2021
…3970)

* knative#3935: Move tag resolution docs

* fix heading

* fix broken link, minor quick edits to operator docs

* Update docs/admin/install/operator/configuring-serving-cr.md

Co-authored-by: RichardJJG <[email protected]>

Co-authored-by: Omer B <[email protected]>
Co-authored-by: RichardJJG <[email protected]>
@abrennan89 abrennan89 deleted the 3935-2 branch August 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/serving lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants