-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3935: Moving tag resolution docs to developer guide #3970
Conversation
✔️ Deploy Preview for knative ready! 🔨 Explore the source changes: 509cb49 🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/60e71967bf25f50007eabe5e 😎 Browse the preview: https://deploy-preview-3970--knative.netlify.app/development/admin/install/operator/configuring-serving-cr |
✔️ Deploy Preview for dev-knative ready! 🔨 Explore the source changes: 76ef4c5 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-knative/deploys/60e61a3b999dc9000770abb6 😎 Browse the preview: https://deploy-preview-3970--dev-knative.netlify.app/development/admin/install/operator/configuring-serving-cr |
If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always | ||
includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is 0.16.x, the | ||
earliest version of Knative Serving available through the Operator is 0.14.0. | ||
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator will do nothing. The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0. | |
If `spec.version` is not specified, the Knative Operator installs the latest available version of Knative Serving. If users specify an invalid or unavailable version, the Knative Operator does nothing. | |
The Knative Operator always includes the latest 3 minor release versions. For example, if the current version of the Knative Operator is v0.24.0, the earliest version of Knative Serving available through the Operator is v0.22.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol thought about doing this but wasn't sure whether to split it. Thanks.
Co-authored-by: RichardJJG <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abrennan89, all looks good.
Should the tag-resolution doc have procedures instead of summaries of what the reader can do, though? Either way, I'd be okay with /lgtm at present. I suspect procedures would be better, but they could be tackled in a separate issue if this content is urgent.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrennan89, RichardJJG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.24 |
@abrennan89: new pull request created: #3981 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yeah probably, I'll leave you to open an issue for this though if you think it's worth doing since it's not really part of the scope here for just moving docs. |
…3970) * knative#3935: Move tag resolution docs * fix heading * fix broken link, minor quick edits to operator docs * Update docs/admin/install/operator/configuring-serving-cr.md Co-authored-by: RichardJJG <[email protected]> Co-authored-by: Omer B <[email protected]> Co-authored-by: RichardJJG <[email protected]>
Partial fix for #3935 , related to #3710
Proposed Changes