Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated landing page #2863

Merged
merged 4 commits into from
Oct 6, 2020
Merged

Updated landing page #2863

merged 4 commits into from
Oct 6, 2020

Conversation

abrennan89
Copy link
Contributor

Fixes #1881

Proposed Changes

  • move Audience information to contributor docs
  • Updated introduction / overview to remove fluff, additional words that don't add value or would be difficult for users to understand

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 28, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2020
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@abrennan89 abrennan89 changed the title [WIP] Updated landing page Updated landing page Oct 5, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2020
@vaikas
Copy link
Contributor

vaikas commented Oct 6, 2020

It's complaining about newlines in pdf files...

  reviewdog: Reporting results for "EOF Newline"
  Error: [EOF Newline] reported by reviewdog 🐶
  Missing newline
  
  Raw Output:
  ./community/contributing/images/logo/rgb/knative-logo-rgb.ai:2518: Missing newline
  Error: [EOF Newline] reported by reviewdog 🐶
  Missing newline
  
  Raw Output:
  ./community/contributing/images/logo/cmyk/knative-logo-cmyk.ai:5594: Missing newline
  Error: Process completed with exit code 1.

vaikas-a01:eventing vaikas$ file !$
file ~/Downloads/knative-logo-rgb.ai
/Users/vaikas/Downloads/knative-logo-rgb.ai: PDF document, version 1.5

@vaikas
Copy link
Contributor

vaikas commented Oct 6, 2020

Aaand, the istio-crds are nowhere to be found, so there's that which is nice...

Context "gke_knative-boskos-58_us-central1_e2e-cls" modified.
- Cluster is gke_knative-boskos-58_us-central1_e2e-cls
- Docker is gcr.io/knative-boskos-58/docs-e2e-img/7916
>> Bringing up Istio
>> Running Istio CRD installer
error: unable to read URL "https://raw.githubusercontent.com/knative-sandbox/net-istio/master/third_party/istio-stable/istio-crds.yaml", server reported 404 Not Found, status code=404

And indeed, they are not there (so not just a transient issue)
vaikas-a01:eventing vaikas$ curl -L 'https://raw.githubusercontent.com/knative-sandbox/net-istio/master/third_party/istio-stable/istio-crds.yaml' > /tmp/istio-crds.yaml
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 14 100 14 0 0 8 0 0:00:01 0:00:01 --:--:-- 8
vaikas-a01:eventing vaikas$ cat /tmp/istio-crds.yaml
404: Not Foundvaikas-a01:eventing vaikas$

@abrennan89
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 1d46f99 into knative:master Oct 6, 2020
@abrennan89 abrennan89 added this to the v0.19.0 milestone Oct 7, 2020
@abrennan89 abrennan89 deleted the 1881 branch May 3, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Knative overview
5 participants