Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps for https://github.com/knative/docs/pull/2377 #2378

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Update deps for https://github.com/knative/docs/pull/2377 #2378

merged 1 commit into from
Apr 10, 2020

Conversation

evankanderson
Copy link
Member

Picking up fix to presubmit-tests.sh from test-infra.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
mattmoor
mattmoor reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@knative-prow-robot knative-prow-robot merged commit cfae952 into knative:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

@samodell samodell Awaiting requested review from samodell

Assignees

@mattmoor mattmoor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evankanderson @knative-prow-robot @mattmoor @googlebot