Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helloworld-go: install CA certs #1143

Merged
merged 2 commits into from
Apr 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion community/samples/serving/helloworld-elixir/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ RUN mix release --env=prod --verbose \
&& mv /opt/release/bin/${APP_NAME} /opt/release/bin/start_server

FROM alpine:latest
RUN apk update && apk --no-cache --update add bash openssl-dev
RUN apk update && apk --no-cache --update add bash openssl-dev ca-certificates

RUN addgroup -g 1000 appuser && \
adduser -S -u 1000 -G appuser appuser
Expand Down
2 changes: 1 addition & 1 deletion community/samples/serving/helloworld-elixir/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ When asked, if you want to `Fetch and install dependencies? [Yn]` select `y`

# Prepare final layer
FROM alpine:latest
RUN apk update && apk --no-cache --update add bash openssl-dev
RUN apk update && apk --no-cache --update add bash openssl-dev ca-certificates

# Add a user so the server will run as a non-root user.
RUN addgroup -g 1000 appuser && \
Expand Down
1 change: 1 addition & 0 deletions docs/install/Knative-with-Gloo.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ RUN CGO_ENABLED=0 GOOS=linux go build -v -o helloworld
# Use a Docker multi-stage build to create a lean production image.
# https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds
FROM alpine
RUN apk add --no-cache ca-certificates

# Copy the binary to the production image from the builder stage.
COPY --from=builder /go/src/github.com/knative/docs/helloworld/helloworld /helloworld
Expand Down
1 change: 1 addition & 0 deletions docs/serving/samples/hello-world/helloworld-go/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ RUN CGO_ENABLED=0 GOOS=linux go build -v -o helloworld
# Use a Docker multi-stage build to create a lean production image.
# https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds
FROM alpine
RUN apk add --no-cache ca-certificates

# Copy the binary to the production image from the builder stage.
COPY --from=builder /go/src/github.com/knative/docs/helloworld/helloworld /helloworld
Expand Down
1 change: 1 addition & 0 deletions docs/serving/samples/hello-world/helloworld-go/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ recreate the source files from this folder.
# Use a Docker multi-stage build to create a lean production image.
# https://docs.docker.com/develop/develop-images/multistage-build/#use-multi-stage-builds
FROM alpine
RUN apk add --no-cache ca-certificates

# Copy the binary to the production image from the builder stage.
COPY --from=builder /go/src/github.com/knative/docs/helloworld/helloworld /helloworld
Expand Down