Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change min K8s version to reflect reality #163

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 23, 2020

  • 0.14 min K8s is 1.15
  • 0.15 min K8s is 1.16
  • 0.16 min K8s will remain 1.16
  • 0.17 min K8s will hopefully be 1.17

Delay is due to availability of stable newer version from providers

I didn't bother predicting 0.18 and beyond

- 0.14 min K8s is 1.15
- 0.15 min K8s is 1.16
- 0.16 min K8s will remain 1.16
- 0.17 min K8s will hopefully be 1.17

Delay is due to availability of stable newer version from providers
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 23, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2020
@dprotaso
Copy link
Member Author

/assign technical-oversight-committee

@knative-prow-robot
Copy link
Contributor

@dprotaso: GitHub didn't allow me to assign the following users: technical-oversight-committee.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign technical-oversight-committee

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2020
@dprotaso
Copy link
Member Author

summoning TOC
/assign evankanderson grantr markusthoemmes mattmoor tcnghia

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just pessimism, or based on actual product announcements?

If we're diverging from the kubernetes upstream release min version, we might also want to update the principles mentioned earlier to call out that we are blocking on one or more of AKS, EKS and GKE.

/lgtm
/approve
/hold

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@dprotaso
Copy link
Member Author

Is this just pessimism, or based on actual product announcements?

0.14 min K8s is 1.15
0.15 min K8s is 1.16

These are amendments to reflect what we supported when we released.

0.16 min K8s will remain 1.16

AKS - Kubernetes version 1.17 will GA on the week of July 1st
GKE - 1.17 is still in the rapid channel
EKS - 1.17 has no release date

Given the lack of availability of 1.17 for the upcoming release I revised it to 1.16.

0.17 min K8s will hopefully be 1.17

The original release is had K8s min version 1.18 - I'm being pessimistic that version will be available

If we're diverging from the kubernetes upstream release min version, we might also want to update the principles mentioned earlier to call out that we are blocking on one or more of AKS, EKS and GKE.

I can bring this up in the ToC meeting to get input but I agree that we need some revisions

@evankanderson
Copy link
Member

From Tim Pepper on slack:

k8s community patch backport support is going to be “one year” (for 1.19 and newer) instead of the previous fuzzy “until the 3rd newer release comes out” which tended to give an strange 9 months (or more? or less?) of patch support depending confusingly on the future project’s release dates

I'm willing to approve this for now with an item to come back and update the principles as the K8s community evolves their rules.

@evankanderson
Copy link
Member

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2020
@knative-prow-robot knative-prow-robot merged commit 1f6bbce into knative:master Jun 25, 2020
@dprotaso dprotaso deleted the master branch April 19, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants