Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds revision get command #97

Merged
merged 5 commits into from
May 13, 2019

Conversation

navidshaikh
Copy link
Collaborator

Fixes #41

./kn revision get
SERVICE   NAME        AGE     CONDITIONS   READY     REASON
n1        n1-twdvc    15h     4 OK / 5     True      
s1        s1-bnpwq    15h     4 OK / 5     True      
s10       s10-xkphp   8m54s   4 OK / 5     True      
s11       s11-4spbx   5s      1 OK / 5     Unknown   Deploying
s12       s12-6284j   65s     5 OK / 5     True      

@knative-prow-robot
Copy link
Contributor

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 9, 2019
@matzew
Copy link
Member

matzew commented May 10, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 10, 2019
@thockin
Copy link

thockin commented May 10, 2019 via email

@cppforlife
Copy link

@thockin github is prolly confused with all the vendored code. removed...

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 13, 2019
@navidshaikh
Copy link
Collaborator Author

@rhuss @sixolet @cppforlife : Rebased and ready for review, PTAL.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/human_readable_flags.go 80.0% 83.3% 3.3
pkg/kn/commands/revision_get.go Do not exist 80.0%
pkg/kn/commands/revision_get_flags.go Do not exist 73.5%

@sixolet
Copy link
Contributor

sixolet commented May 13, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2019
@knative-prow-robot knative-prow-robot merged commit 39034a7 into knative:master May 13, 2019
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
* Renames test names for service get command

 also removes unnecessary commented imports

* Adds revision get command

 renames `revision list` ==> `revision get`

* Adds tests for revision get command

* Updates the vendors/modules.txt

* Removes revision list command
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
* Renames test names for service get command

 also removes unnecessary commented imports

* Adds revision get command

 renames `revision list` ==> `revision get`

* Adds tests for revision get command

* Updates the vendors/modules.txt

* Removes revision list command
maximilien pushed a commit to maximilien/client that referenced this pull request May 14, 2019
* Renames test names for service get command

 also removes unnecessary commented imports

* Adds revision get command

 renames `revision list` ==> `revision get`

* Adds tests for revision get command

* Updates the vendors/modules.txt

* Removes revision list command
dsimansk pushed a commit to dsimansk/client that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more details in the output of revision list command
7 participants