-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds revision get command #97
Adds revision get command #97
Conversation
Hi @navidshaikh. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ac7be2a
to
f051f08
Compare
/ok-to-test |
Why am I a reviewer for this?
…On Fri, May 10, 2019 at 2:38 AM Knative Prow Robot ***@***.***> wrote:
@navidshaikh: The following tests failed, say /retest to rerun them all:
Test name Commit Details Rerun command
pull-knative-client-build-tests f051f08 link /test pull-knative-client-build-tests
pull-knative-client-integration-tests f051f08 link /test pull-knative-client-integration-tests
pull-knative-client-go-coverage f051f08 link /test pull-knative-client-go-coverage
pull-knative-client-unit-tests f051f08 link /test pull-knative-client-unit-tests
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@thockin github is prolly confused with all the vendored code. removed... |
also removes unnecessary commented imports
renames `revision list` ==> `revision get`
f051f08
to
a2adc05
Compare
@rhuss @sixolet @cppforlife : Rebased and ready for review, PTAL. |
The following is the coverage report on pkg/.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Renames test names for service get command also removes unnecessary commented imports * Adds revision get command renames `revision list` ==> `revision get` * Adds tests for revision get command * Updates the vendors/modules.txt * Removes revision list command
* Renames test names for service get command also removes unnecessary commented imports * Adds revision get command renames `revision list` ==> `revision get` * Adds tests for revision get command * Updates the vendors/modules.txt * Removes revision list command
* Renames test names for service get command also removes unnecessary commented imports * Adds revision get command renames `revision list` ==> `revision get` * Adds tests for revision get command * Updates the vendors/modules.txt * Removes revision list command
Fixes #41