Fix Panic for kn source apiserver and kn source binding describe with Sink URI #901
Conversation
There was a problem hiding this comment.
@danielhelfand: 0 warnings.
In response to this:
Description
Following up on #848 and #900, this pull request updates
kn source apiserverandkn source binding describeto avoid a panic when using a Sink that has a URI instead of a Ref.This pull request also updates unit tests for
apiserverandbindingas some tests are not asserting whether output of commands is correct./lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
needs-ok-to-test
|
Hi @danielhelfand. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/L
danielhelfand
changed the title
danielhelfand
force-pushed
the
panic_apiserver_binding
branch
from
22891d6 to
2410198
Compare
|
/ok-to-test |
knative-prow-robot
added
ok-to-test
| sinkRefsvc1 = duckv1.Destination{ | ||
| Ref: &duckv1.KReference{ | ||
| Kind: "Service", | ||
| Name: "svc1", | ||
| APIVersion: "serving.knative.dev/v1", | ||
| Namespace: "default", | ||
| }, | ||
| } | ||
|
|
||
| sinkRefsvc2 = duckv1.Destination{ | ||
| Ref: &duckv1.KReference{ | ||
| Kind: "Service", | ||
| Name: "svc2", | ||
| APIVersion: "serving.knative.dev/v1", | ||
| Namespace: "default", | ||
| }, | ||
| } |
There was a problem hiding this comment.
how about function sinkv1(service, namespace, string) and use that inline wherever needed ?
(could be done in a follow up)
There was a problem hiding this comment.
I have added a createSinkv1 func in apiserver_test.go. Turns out this same func exists for binding already as createServiceSink. If there is a location to recommend, we could use the same func for both, but let me know what's preferred with regard to that.
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
|
/test pull-knative-client-integration-tests |
|
Please address @navidshaikh comments. Otherwise LGTM |
Should all be addressed, but can wait for @navidshaikh to clarify if I've missed anything. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Following up on #848 and #900, this pull request updates
kn source apiserverandkn source binding describeto avoid a panic when using a Sink that has a URI instead of a Ref.This pull request also updates unit tests for
apiserverandbindingas some tests are not asserting whether output of commands is correct./lint