-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --ce-override flag for apiserver and ping sources #865
Add --ce-override flag for apiserver and ping sources #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navidshaikh: 3 warnings.
In response to this:
Description
- Add --ce-override flag apiserver, ping sources and update it for SinkBinding.
Changes
- Updated map handling utilities, cloud events extensions builder method, flag description and related unit tests for SinkBinding
- Added --ce-override flag and unit tests for APIServer and Ping sources
Reference
Fixes #849
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
bfe8a98
to
cdc98fc
Compare
- Add unit tests - Update flag description - Update parsing utilities for map
- Add --ce-override flag - Add unit tests
- Add --ce-override flag - Add unit tests
08dacb7
to
7ca4200
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. In the future, we might consider extracting the common part to be reused, but for that, we should then also think about kind of a common template for kn source describe
functionality.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Changes
Reference
Fixes #849
/lint