Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ce-override flag for apiserver and ping sources #865

Merged

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented May 29, 2020

Description

  • Add --ce-override flag for apiserver, ping sources and update it for SinkBinding.
  • Show ce-override extensions for apiserver and ping sources, in describe output if present.

Changes

  • Updated map handling utilities, cloud events extensions builder method, flag description and related unit tests for SinkBinding
  • Added --ce-override flag and unit tests for APIServer and Ping sources

Reference

Fixes #849

/lint

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 29, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidshaikh: 3 warnings.

In response to this:

Description

  • Add --ce-override flag apiserver, ping sources and update it for SinkBinding.

Changes

  • Updated map handling utilities, cloud events extensions builder method, flag description and related unit tests for SinkBinding
  • Added --ce-override flag and unit tests for APIServer and Ping sources

Reference

Fixes #849

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/sources/v1alpha2/apiserver_client.go Show resolved Hide resolved
pkg/sources/v1alpha2/ping_client.go Show resolved Hide resolved
pkg/sources/v1alpha2/binding_client.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 29, 2020
@navidshaikh navidshaikh force-pushed the pr/ce-overrides-flags branch from bfe8a98 to cdc98fc Compare May 29, 2020 12:07
@navidshaikh navidshaikh force-pushed the pr/ce-overrides-flags branch from 08dacb7 to 7ca4200 Compare June 1, 2020 08:42
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/source/apiserver/create.go 84.8% 83.3% -1.5
pkg/kn/commands/source/apiserver/describe.go 82.7% 85.2% 2.6
pkg/kn/commands/source/apiserver/flags.go 70.0% 70.2% 0.2
pkg/kn/commands/source/apiserver/update.go 74.4% 75.5% 1.1
pkg/kn/commands/source/binding/binding.go 60.0% 57.4% -2.6
pkg/kn/commands/source/binding/create.go 81.6% 82.1% 0.5
pkg/kn/commands/source/binding/update.go 75.6% 77.1% 1.5
pkg/kn/commands/source/ping/create.go 88.9% 87.1% -1.8
pkg/kn/commands/source/ping/describe.go 83.7% 87.3% 3.6
pkg/kn/commands/source/ping/flags.go 56.2% 57.1% 0.9
pkg/kn/commands/source/ping/update.go 76.3% 77.3% 1.0
pkg/sources/v1alpha2/apiserver_client.go 93.2% 90.9% -2.3
pkg/sources/v1alpha2/binding_client.go 85.9% 85.4% -0.5
pkg/sources/v1alpha2/ping_client.go 91.4% 89.1% -2.3
pkg/util/parsing_helper.go 88.2% 86.8% -1.4

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. In the future, we might consider extracting the common part to be reused, but for that, we should then also think about kind of a common template for kn source describe functionality.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c1de0ad into knative:master Jun 1, 2020
@navidshaikh navidshaikh deleted the pr/ce-overrides-flags branch June 1, 2020 10:44
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --ce-override on ping and apiserver sources
5 participants