Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables and unreachable code #779

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Remove unused variables and unreachable code #779

merged 1 commit into from
Apr 6, 2020

Conversation

navidshaikh
Copy link
Collaborator

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 6, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/describe.go 73.1% 73.9% 0.8

@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2020

This pull request fixes 5 alerts when merging 91ec575 into 2e4ff2b - view on LGTM.com

fixed alerts:

  • 4 for Useless assignment to local variable
  • 1 for Unreachable statement

maximilien
maximilien approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 8a60d2e into knative:master Apr 6, 2020
@navidshaikh navidshaikh deleted the pr/lgtm-fixes branch April 7, 2020 07:03
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@srinivashegde86 @knative-prow-robot
Make using profiler optional when using loadgenerator (knative#779)
8daf339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navidshaikh @knative-metrics-robot @knative-prow-robot @maximilien @googlebot