feature(serving): Update API to serving.knative.dev/v1 #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an issue with 0.12.0 (a missing constant) the update also includes an update to the latest knative-serving and knative-eventing dependencies from master (as reflected in version.go) Signed-off-by: Roland Huß <[email protected]>
knative-prow-robot
added
approved
|
/retest |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
/retest |
@navidshaikh any idea how we could fix that ? For me it looks like a backend race condition within serving though. We would need to isolate the test (e.g. the concrete backend calls) and then pen an issue in serving. |
|
@navidshaikh tests are green now, not sure how to review this beast best though ;-) |
navidshaikh
approved these changes
Feb 7, 2020
Comment on lines
+26
to
29
| dynamicfake "k8s.io/client-go/dynamic/fake" | ||
| eventingv1alpha1 "knative.dev/eventing/pkg/apis/eventing/v1alpha1" | ||
| servingv1 "knative.dev/serving/pkg/apis/serving/v1" | ||
| ) |
Comment on lines
249
to
251
| if p.AnyMutation(cmd) { | ||
| err = servinglib.UpdateName(template, name) | ||
| if err == servinglib.ApiTooOldError && !cmd.Flags().Changed("revision-name") { | ||
| // Ignore the error if we don't support revision names and nobody | ||
| // explicitly asked for one. | ||
| } else if err != nil { | ||
| return err | ||
| } | ||
| template.Name = name | ||
| } |
Comment on lines
-192
to
+188
| template, err := servinglib.RevisionTemplateOfService(service) | ||
| assert.NilError(t, err) | ||
| template.Spec.GetContainer().EnvFrom = []corev1.EnvFromSource{ | ||
| template := &service.Spec.Template | ||
| template.Spec.Containers[0].EnvFrom = []corev1.EnvFromSource{ |
| }, | ||
| } | ||
|
|
||
| // ResolveSink returns the Destination referred to by the flags in the acceptor. | ||
| // It validates that any object the user is referring to exists. | ||
| func (i *SinkFlags) ResolveSink(knclient kn_dynamic.KnDynamicClient, namespace string) (*duckv1beta1.Destination, error) { | ||
| func (i *SinkFlags) ResolveSink(knclient clientdynamic.KnDynamicClient, namespace string) (*duckv1.Destination, error) { |
Comment on lines
+636
to
+637
| func getRevisionTemplate() (*servingv1.RevisionTemplateSpec, *corev1.Container) { | ||
| template := &servingv1.RevisionTemplateSpec{ |
| func getV1alpha1Service() (*servingv1alpha1.Service, *servingv1alpha1.RevisionTemplateSpec, *corev1.Container) { | ||
| template, container := getV1alpha1RevisionTemplateWithOldFields() | ||
| service := &servingv1alpha1.Service{ | ||
| func getV1alpha1Service() (*servingv1.Service, *servingv1.RevisionTemplateSpec, *corev1.Container) { |
There was a problem hiding this comment.
Suggested change
| func getV1alpha1Service() (*servingv1.Service, *servingv1.RevisionTemplateSpec, *corev1.Container) { | |
| func getV1Service() (*servingv1.Service, *servingv1.RevisionTemplateSpec, *corev1.Container) { |
We can rename the function in a subsequent PR.
| sink := &v1.Destination{ | ||
| Ref: &v12.ObjectReference{Name: sinkService, Kind: "Service", Namespace: "default", APIVersion: "serving.knative.dev/v1alpha1"}, | ||
| sink := &duckv1.Destination{ | ||
| Ref: &duckv1.KReference{Name: sinkService, Kind: "Service", Namespace: "default", APIVersion: "serving.knative.dev/v1"}, |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an issue with 0.12.0 (a missing constant) the update also includes an update
to the latest knative-serving and knative-eventing dependencies from master
(as reflected in version.go)