Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes(#308): adds e2e tests for plugins #591

Merged
merged 3 commits into from
Jan 9, 2020
Merged

fixes(#308): adds e2e tests for plugins #591

merged 3 commits into from
Jan 9, 2020

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented Dec 23, 2019 •
edited
Loading

Fixes #308

Proposed Changes

  • adds test/e2e/plugins_test.go
  • adds a new option to e2eTest to prevent namespace creation (since some test might not need ns)

Release Note:

  • 🧽 backfill e2e tests for plugins

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 23, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 23, 2019
@maximilien
Copy link
Contributor Author

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 23, 2019
@maximilien maximilien changed the title adds e2e tests for plugins fixes(#308): adds e2e tests for plugins Dec 23, 2019
navidshaikh
navidshaikh requested changes Dec 30, 2019
View reviewed changes
test/e2e/plugins_test.go Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/plugins_test.go Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/plugins_test.go Show resolved Hide resolved
test/e2e/plugins_test.go Outdated Show resolved Hide resolved
test/e2e/common.go Show resolved Hide resolved
@maximilien
Copy link
Contributor Author

@navidshaikh I need to work on this a bit more. Will submit updates sometimes tomorrow.

@maximilien
Copy link
Contributor Author

@navidshaikh I need to work on this a bit more. Will submit updates sometimes tomorrow.

Actually, got a bit of breather with other things and completed it before leaving for home. See update. Thanks.

@maximilien
Copy link
Contributor Author

maximilien commented Jan 7, 2020 •
edited
Loading

@navidshaikh I am not sure why the IT tests failed. Seems like the plugins e2e tests passed see this snipet of the output. Let me try it again.

@maximilien
Copy link
Contributor Author

/retest

@navidshaikh
Copy link
Collaborator

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@knative-prow-robot knative-prow-robot merged commit a0910db into knative:master Jan 9, 2020
@maximilien maximilien deleted the issue308 branch January 9, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh navidshaikh requested changes

@cppforlife cppforlife Awaiting requested review from cppforlife

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kn plugins integration test
4 participants
@maximilien @knative-prow-robot @navidshaikh @googlebot