Add trigger update command #562
Conversation
knative-prow-robot
added
the
size/XL
|
/retest |
| } | ||
|
|
||
| // UpdateFilters to update the filters of trigger object | ||
| func (b *TriggerBuilder) UpdateFilters(toUpdate map[string]string, toRemove []string) *TriggerBuilder { |
There was a problem hiding this comment.
I wouldn't do any removal or change in the builder. Its about creating an immutable object, so would prefer to have just a Filter() method (as in my PR ;-) if you don't mind I would update that later.
There was a problem hiding this comment.
Fine. I don't mind. Feel free to update it in a following PR.
daisy-ycguo
force-pushed
the
trigger
branch
2 times, most recently
from
c7ba214 to
95c023b
Compare
| } | ||
|
|
||
| // Sink to set the subscriber of trigger object | ||
| func (b *TriggerBuilder) Sink(sink *duckv1.Destination) *TriggerBuilder { |
There was a problem hiding this comment.
Let's call it Subscriber like in the spec.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
The following is the coverage report on the affected files.
|
Proposed Changes