Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trigger list #558

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add trigger list #558

merged 1 commit into from
Dec 17, 2019

Conversation

daisy-ycguo
Copy link
Member

@daisy-ycguo daisy-ycguo commented Dec 17, 2019 •
edited
Loading

Fixes #516

Proposed Changes

  • Add command to list trigger
  • Mark sink as required in trigger create and source apiserver create

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2019
@daisy-ycguo daisy-ycguo force-pushed the trigger branch 8 times, most recently from cd5a878 to 05516e2 Compare December 17, 2019 08:08
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/v1alpha1/client.go 92.9% 86.7% -6.2
pkg/eventing/v1alpha1/client_mock.go 87.5% 89.5% 2.0
pkg/kn/commands/flags/list.go Do not exist 62.5%
pkg/kn/commands/source/apiserver/create.go 85.2% 85.7% 0.5
pkg/kn/commands/trigger/list.go Do not exist 80.8%
pkg/kn/commands/trigger/list_flags.go Do not exist 81.6%
pkg/kn/commands/trigger/update_flags.go Do not exist 93.8%

rhuss
rhuss approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for now, some duplicated code should be consolidated so that list commands share the same way of doing the listing (eg. for with and without namespace)

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@knative-prow-robot knative-prow-robot merged commit 60b8801 into knative:master Dec 17, 2019
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@dubee @knative-prow-robot
Fix typo doc (knative#558)
bbeed9e 
* Fix type in README

* Fix typoe in apicoverage README

* Revert correction in apicoverage
creydr added a commit to creydr/knative-client that referenced this pull request Jan 13, 2025
@creydr
[release-v1.15] Update kn-plugin-event to latest 1.15 version (knativ…
56b5c25 
…e#558)

openshift-knative/kn-plugin-event#644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn trigger list
5 participants
@daisy-ycguo @knative-metrics-robot @knative-prow-robot @rhuss @googlebot