kn source list-types (builtin types) #536

navidshaikh · 2019-12-06T12:52:06Z

Part of #511

/lint

Proposed Changes

Only lists the builtin source types
Uses client-go dynamic client for listing CRDs
Adds DyanmicClient interface to KnParams
Adds printing options

Example:

Command:

kn source list-types
TYPE              NAME                                            DESCRIPTION
ApiServerSource   apiserversources.sources.eventing.knative.dev   Kubernetes API Server events source
ContainerSource   containersources.sources.eventing.knative.dev   Container events source
CronJobSource     cronjobsources.sources.eventing.knative.dev     CronJob events source

Print flags:

./kn source list-types --help    
List available source types

Usage:
  kn source list-types [flags]

Flags:
      --allow-missing-template-keys   If true, ignore any errors in templates when a field or map key is missing in the template. Only applies to golang and jsonpath output formats.
                                      (default true)
  -h, --help                          help for list-types
  -n, --namespace string              Specify the namespace to operate in.
      --no-headers                    When using the default output format, don't print headers (default: print headers).
  -o, --output string                 Output format. One of: json|yaml|name|go-template|go-template-file|template|templatefile|jsonpath|jsonpath-file.
      --template string               Template string or path to template file to use when -o=go-template, -o=go-template-file. The template format is golang templates
                                      [http://golang.org/pkg/text/template/#pkg-overview].

Global Flags:
      --config string       kn config file (default is $HOME/.kn/config.yaml)
      --kubeconfig string   kubectl config file (default is $HOME/.kube/config)
      --log-http            log http traffic

knative-prow-robot

@navidshaikh: 6 warnings.

In response to this:

Part of #511

/lint

Proposed Changes

Only lists the builtin source types
Uses client-go dynamic client for listing CRDs
Adds DyanmicClient interface to KnParams
Adds printing options

Example:

Command:

kn source list-types
TYPE              NAME                                            DESCRIPTION
ApiServerSource   apiserversources.sources.eventing.knative.dev   Kubernetes API Server events source
ContainerSource   containersources.sources.eventing.knative.dev   Container events source
CronJobSource     cronjobsources.sources.eventing.knative.dev     CronJob events source

Print flags:

./kn source list-types --help    
List available source types

Usage:
 kn source list-types [flags]

Flags:
     --allow-missing-template-keys   If true, ignore any errors in templates when a field or map key is missing in the template. Only applies to golang and jsonpath output formats.
                                     (default true)
 -h, --help                          help for list-types
 -n, --namespace string              Specify the namespace to operate in.
     --no-headers                    When using the default output format, don't print headers (default: print headers).
 -o, --output string                 Output format. One of: json|yaml|name|go-template|go-template-file|template|templatefile|jsonpath|jsonpath-file.
     --template string               Template string or path to template file to use when -o=go-template, -o=go-template-file. The template format is golang templates
                                     [http://golang.org/pkg/text/template/#pkg-overview].

Global Flags:
     --config string       kn config file (default is $HOME/.kn/config.yaml)
     --kubeconfig string   kubectl config file (default is $HOME/.kube/config)
     --log-http            log http traffic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/source/list_types.go

pkg/kn/commands/source/human_readable_flags.go

pkg/kn/commands/source/list_types_flags.go

pkg/kn/commands/source/source.go

pkg/dynamic/client.go

knative-prow-robot · 2019-12-06T12:52:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

navidshaikh · 2019-12-10T10:09:40Z

/lint

knative-prow-robot

@navidshaikh: 2 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/kn/commands/source/source.go

pkg/kn/commands/testing_helper.go

navidshaikh · 2019-12-10T11:31:57Z

/test pull-knative-client-integration-tests

boskos

- Only lists the builtin source types - Uses client-go dynamic client for listing CRDs - Adds DyanmicClient interface to KnParams - Adds printing options

GVR as: - Group: apiextensions.k8s.io - Version: v1beta1 - Resource: customresourcedefinitions Label as: {"duck.knative.dev/source": "true"}

as - "Binding Pattern for ContainerSource"

- also test the YAML output

- Update the unit tests accordingly

knative-metrics-robot · 2019-12-10T15:04:25Z

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/dynamic/client.go	Do not exist	90.9%
pkg/kn/commands/source/human_readable_flags.go	Do not exist	87.0%
pkg/kn/commands/source/list_types.go	Do not exist	70.8%
pkg/kn/commands/source/list_types_flags.go	Do not exist	66.7%
pkg/kn/commands/source/source.go	Do not exist	100.0%
pkg/kn/commands/testing_helper.go	58.8%	64.4%	5.6
pkg/kn/commands/types.go	61.4%	62.2%	0.9

sixolet · 2019-12-10T19:20:19Z

/lgtm

* Make all github calls as receivable by github client * Remove client and user vars as they are handled in ghIssue * Rename to NewGithubclient as we are creating a new client

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2019

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 6, 2019

knative-prow-robot requested review from cppforlife and rhuss December 6, 2019 12:52

knative-prow-robot reviewed Dec 6, 2019

View reviewed changes

knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 6, 2019

navidshaikh force-pushed the pr/list-types branch from be1e0a8 to f60b34f Compare December 6, 2019 14:16

navidshaikh force-pushed the pr/list-types branch 2 times, most recently from ba215b8 to 52c2311 Compare December 9, 2019 11:37

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 9, 2019

navidshaikh force-pushed the pr/list-types branch from c5383f2 to f526899 Compare December 9, 2019 18:54

navidshaikh changed the title ~~[WIP]feat: kn source list-types (builtin types)~~ kn source list-types (builtin types) Dec 10, 2019

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019

knative-prow-robot reviewed Dec 10, 2019

View reviewed changes

pkg/kn/commands/source/source.go Outdated Show resolved Hide resolved

pkg/kn/commands/testing_helper.go Show resolved Hide resolved

navidshaikh added 8 commits December 10, 2019 20:24

feat: kn source list-types (builtin types)

860de17

- Only lists the builtin source types - Uses client-go dynamic client for listing CRDs - Adds DyanmicClient interface to KnParams - Adds printing options

chore(lint): Address golint suggestions

f57423e

Rebase and update venodr/modules.txt

fb9304c

Adds unit tests for DynamicClient in types.go

e632a0e

Add kn source list-types command in smoke tests

5c7c510

Constants for the CRD GVR and source identifier label key value

34a3e63

GVR as: - Group: apiextensions.k8s.io - Version: v1beta1 - Resource: customresourcedefinitions Label as: {"duck.knative.dev/source": "true"}

Add tests for dynamic client

ec31a89

Add description about SinkBinding source type

0930992

as - "Binding Pattern for ContainerSource"

navidshaikh added 11 commits December 10, 2019 20:24

Remove unused imports

23c32cb

Adds unit tests for list-types command processing

47765bc

More unit tests for flags

6d27578

Adds e2e tests for kn source list-types

accd4da

- also test the YAML output

Sort the source types while listing them

2c5e3bc

- Update the unit tests accordingly

Add examples

ed6f94f

Add unit tests for CreateDynamicTestKnCommand

4e9b4ff

Fix typo in unit tests

4ab42d9

golint fixes

8cecf81

Updates to vendor/modules.txt after rebase

5b24447

Remove the extra lines

ef4faf3

navidshaikh force-pushed the pr/list-types branch from 33eb009 to ef4faf3 Compare December 10, 2019 15:02

knative-prow-robot assigned sixolet Dec 10, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019

knative-prow-robot merged commit 7dbb5a5 into knative:master Dec 10, 2019

navidshaikh deleted the pr/list-types branch December 18, 2019 11:09

dsimansk added a commit to dsimansk/client that referenced this pull request Dec 6, 2024

Add platform target to Makefile (knative#536)

9463165

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kn source list-types (builtin types) #536

kn source list-types (builtin types) #536

navidshaikh commented Dec 6, 2019

knative-prow-robot left a comment

knative-prow-robot commented Dec 6, 2019

navidshaikh commented Dec 10, 2019

knative-prow-robot left a comment

navidshaikh commented Dec 10, 2019

knative-metrics-robot commented Dec 10, 2019

sixolet commented Dec 10, 2019

kn source list-types (builtin types) #536

kn source list-types (builtin types) #536

Conversation

navidshaikh commented Dec 6, 2019

Proposed Changes

knative-prow-robot left a comment

Choose a reason for hiding this comment

Proposed Changes

knative-prow-robot commented Dec 6, 2019

navidshaikh commented Dec 10, 2019

knative-prow-robot left a comment

Choose a reason for hiding this comment

navidshaikh commented Dec 10, 2019

knative-metrics-robot commented Dec 10, 2019

sixolet commented Dec 10, 2019