Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Knative Serving 0.10.0 #474

Merged
merged 3 commits into from
Nov 4, 2019

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Nov 4, 2019

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 4, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 4, 2019
@rhuss
Copy link
Contributor Author

rhuss commented Nov 4, 2019

LOL, this error is funny:

📖 Docs
ERROR: Modified files found:
?? vendor/sigs.k8s.io/kustomize/pkg/target/
ERROR: Diff

I haven't committed this vendodered target directory because it's in my default .gitignore. You guess where I'm coming from, Java was my second love and you never commit Maven's target dirs.

(btw, now you have to guess what my first big programmaning language love ;-)

Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@knative-prow-robot knative-prow-robot merged commit d8d0192 into knative:master Nov 4, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
build test default test runner could fail at checking licenses step if there is no go code exists in a repo, as it's expecting at least one path passed in as parameter. Check if there is any go code before running build test
dsimansk added a commit to dsimansk/client that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants