Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(changelog): Add a changelog #241

Merged
merged 1 commit into from
Jul 9, 2019
Merged

chore(changelog): Add a changelog #241

merged 1 commit into from
Jul 9, 2019

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Jul 8, 2019

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 8, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2019
@rhuss
chore(changelog): Add a changelog.adoc
77e93bf 
and added features for 0.2.0
@rhuss rhuss added this to the v0.2.0 milestone Jul 8, 2019
@rhuss rhuss closed this Jul 8, 2019
@rhuss
Copy link
Contributor Author

rhuss commented Jul 8, 2019

/retest

@rhuss rhuss reopened this Jul 8, 2019
@rhuss rhuss mentioned this pull request Jul 8, 2019
Closed
@cppforlife
Copy link

@rhuss what's the rationale for having this file? is it for devs or end users?

@rhuss
Copy link
Contributor Author

rhuss commented Jul 9, 2019

@rhuss what's the rationale for having this file? is it for devs or end users?

end users, a curated list which is growing while going and not as an afterthought when doing a release.

@rhuss
Copy link
Contributor Author

rhuss commented Jul 9, 2019

the format of this changelog is kind of experimental, happy to revert it to a more conventional (bullet list like) format.

@sixolet
Copy link
Contributor

sixolet commented Jul 9, 2019

/lgtm
I like emoji

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@rhuss
Copy link
Contributor Author

rhuss commented Jul 9, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit d01e715 into knative:master Jul 9, 2019
navidshaikh added a commit to navidshaikh/client that referenced this pull request Jan 21, 2020
@navidshaikh @openshift-merge-robot
docs: Create knative-client release (knative#241)
11aec5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@sixolet sixolet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rhuss @knative-prow-robot @cppforlife @sixolet @googlebot