feat(build.sh): Enable goimports + cleanup imports in source files #186
Conversation
knative-prow-robot
added
the
size/M
hack/build.sh
Outdated
| @@ -61,6 +61,9 @@ run() { | |||
| # Format source code | |||
| go_fmt | |||
|
|
|||
| # Cleanup imports | |||
| go_imports | |||
There was a problem hiding this comment.
Minor... same as comment to go_fmt. I'd move anything that changes the code before compile and test.
There was a problem hiding this comment.
I will change the order in another PR, just let those get merged first.
hack/build.sh
Outdated
| @@ -61,6 +61,10 @@ run() { | |||
| # Format source code | |||
| go_fmt | |||
There was a problem hiding this comment.
should we remove the go_fmt now? since, in addition to fixing imports, goimports also formats code in the same style as gofmt.
There was a problem hiding this comment.
ah, ok. I thought they do different things. Let me check.
rhuss
changed the title
|
/approve |
knative-prow-robot
added
lgtm
Much like 'go fmt' for cleaning up go source, 'goimports' can help in properly formatting and grouping imports. See https://goinbigdata.com/goimports-vs-gofmt/ for a quick overview. This commit also cleansup imports on existing files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhuss, sixolet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
And changed order so that formatting and import reordering comes before compiling and testing
|
/lgtm |
…native#186) * feat(build.sh): Enable goimports for cleanup imports + cleanup imports Much like 'go fmt' for cleaning up go source, 'goimports' can help in properly formatting and grouping imports. See https://goinbigdata.com/goimports-vs-gofmt/ for a quick overview. This commit also cleansup imports on existing files. * fix(build): Add missing space for output on iterm * chore(build): Merged gofmt and goimports And changed order so that formatting and import reordering comes before compiling and testing
Much like 'go fmt' for cleaning up go source, 'goimports' can help
in properly formatting and grouping imports. See https://goinbigdata.com/goimports-vs-gofmt/
for a quick overview.
This commit also cleansup imports on existing files.