-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for panic during channel list #1568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vyasgun: 0 warnings.
In response to this:
Description
kn channel list
was panicking when a channel in the list didn't have.Spec.ChannelTemplate
field set to a non-nil value.Changes
- Added a nil check
Reference
Fixes #
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Codecov Report
@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 79.65% 79.70% +0.04%
==========================================
Files 163 163
Lines 8616 8686 +70
==========================================
+ Hits 6863 6923 +60
- Misses 1072 1078 +6
- Partials 681 685 +4
Continue to review full report at Codecov.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
kn channel list
was panicking when a channel in the list didn't have.Spec.ChannelTemplate
field set to a non-nil value.Changes
Reference
Fixes #