Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service update): Only update fields which have been sent by server. #155

Merged
merged 3 commits into from
Jun 3, 2019
Merged

fix(service update): Only update fields which have been sent by server. #155

merged 3 commits into from
Jun 3, 2019

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented May 31, 2019

This reflects the lemonade process step1. Tests have been adapted to
verify this behaviours.

The only situation when we update field coming from the server is for
"kn service update" for envs, image and requests/limits.

All other operation are either create (here, we always have to send the
old fields), or read (get/describe).

Fixes #144.

@rhuss
fix(service update): Only update fields which have been sent by server.
d2d9a8b 
This reflects the lemonade process step1. Tests have been adapted to
verify this behaviours.

The only situation when we update field coming from the server is for
"kn service update" for envs, image and requests/limits.

All other operation are either create (here, we always have to send the
old fields), or read (get/describe).

Fixes knative#144.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 31, 2019
@knative-prow-robot
Copy link
Contributor

Hi @rhuss. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 31, 2019
@rhuss
Copy link
Contributor Author

rhuss commented May 31, 2019

/assign sixolet

rhuss added 2 commits June 1, 2019 14:23
@rhuss
chore: typo fix
dd6decd
@rhuss
refactor(service update/create): Moved from Configuration to Revision…
4f30bbc 
…TemplateSpec

In order to proper handling the v1alpha1 -> v1beta1 migration methods has been updated to get rid fo Configuration within the service as this
is completely inlined in v1beta1.

The helper methods have been also updated accordingly.
I think we are good now.
@rhuss rhuss mentioned this pull request Jun 2, 2019
Closed
@cppforlife cppforlife added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 3, 2019
@cppforlife
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/configuration_edit_flags.go 81.8% 80.4% -1.4
pkg/kn/commands/service_update.go 73.1% 75.0% 1.9
pkg/serving/config_changes.go 58.6% 57.1% -1.5

This was referenced Jun 3, 2019
Merged
Merged
@rhuss
Copy link
Contributor Author

rhuss commented Jun 3, 2019

/retest

@rhuss rhuss mentioned this pull request Jun 3, 2019
Merged
@sixolet
Copy link
Contributor

sixolet commented Jun 3, 2019

/lgtm
/approve
I love when I read a largeish PR and it just looks right...

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2019
@knative-prow-robot knative-prow-robot merged commit b6a8fa9 into knative:master Jun 3, 2019
@rhuss rhuss added this to the v0.2.0 milestone Jun 9, 2019
@rhuss rhuss deleted the pr/unnested-fields-144 branch March 9, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@sixolet sixolet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Return unnnested fields when server provides unnested fields
6 participants
@rhuss @knative-prow-robot @cppforlife @knative-metrics-robot @sixolet @googlebot