Add --tag flag to service create and allow traffic split <100 when @latest is specified

[vyasgun]

Description

Add --tag flag to service create and interpret just value arguments to the flag as @latest=value
When @latest is specified as argument to --traffic and sum < 100, calculate the remaining revision

Changes

• The arguments that don't follow key=value format and just value format will be treated as @latest=value
• service create will have a --tag flag so revision is created with a tag
• Updating traffic split for a service when @latest is specified and the total sum is less than 100 for a service with N revisions will work as follows:
  • If the update leads to a new revision creation, total N key=value arguments need to be specified for --traffic
  • If the update does not create a new revision, total N-1 key=value arguments need to be specified for --traffic

Reference

Fixes #

[knative-prow-robot]

@vyasgun: 3 warnings.

In response to this:

Description

Add --tag flag to service create and interpret just value arguments to the flag as @latest=value

Changes

• The arguments that don't follow key=value format and just value format will be treated as @latest=value
• service create will have a --tag flag so revision is created with a tag

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1514 (1b44096) into main (09d48d5) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   79.34%   79.52%   +0.18%     
==========================================
  Files         162      162              
  Lines        8502     8553      +51     
==========================================
+ Hits         6746     6802      +56     
+ Misses       1075     1073       -2     
+ Partials      681      678       -3     

Impacted Files	Coverage Δ
pkg/kn/commands/flags/traffic.go	100.00% <100.00%> (ø)
pkg/kn/commands/service/create.go	80.59% <100.00%> (+1.23%)	⬆️
pkg/kn/commands/service/update.go	81.42% <100.00%> (ø)
pkg/kn/traffic/compute.go	100.00% <100.00%> (ø)
pkg/kn/commands/container/add.go	94.87% <0.00%> (+0.13%)	⬆️
pkg/kn/commands/source/container/update.go	90.69% <0.00%> (+0.22%)	⬆️
pkg/kn/commands/source/container/create.go	90.24% <0.00%> (+0.24%)	⬆️
...kg/kn/commands/service/configuration_edit_flags.go	83.53% <0.00%> (+0.83%)	⬆️
pkg/kn/commands/revision/describe.go	51.51% <0.00%> (+0.89%)	⬆️
pkg/kn/config/config.go	54.25% <0.00%> (+1.31%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d48d5...1b44096. Read the comment docs.

[maximilien]

Thanks for contribution. Left one comment

[dsimansk]

Thanks @vyasgun! I can say that the code finally settled with me and I understand the motivation and changes. :)

/approve

@rhuss: Would you have time to take a look?

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/create.go	87.9%	88.7%	0.8

[dsimansk]

Thanks!

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhuss]

Sorry for being so late. I will give the whole traffic refactorings a spin today (or early next week).