Add support to (not) initialize kn config file

[boaz0]

Description

Add support to initialize kn config file or to skip it.
Make a default config file with the newest settings if it doesn't exist.

Changes

• Add --init flag
• Add --no-init flag
• By default we read the config file and if it doesn't exist create it
• Instead of return null if config file does not exist, create and populate it with default settings
• Set the default settings to what mentioned here: https://github.com/knative/client/blob/main/docs/README.md#options
• Use viper to create the config file.

Reference

Related #1232

[knative-prow-robot]

@boaz0: 0 warnings.

In response to this:

Description

Add support to initialize kn config file or to skip it.

Changes

• Add --init flag
• Add --no-init flag
• By default we read the config file and if it doesn't exist create it
• Use viper to create the config file.

Reference

Fixes #1232

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @boaz0. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maximilien]

/ok-to-test
Thanks for submission. Left one comment and one question: why would this initialization not done automatically if the file is not present or cannot be loaded?

[dsimansk]

Can you please add a new ## Unreleased table to start collecting changes for the next release?

[boaz0]

Thanks @dsimansk I will look at it more (+ rebase my code) and address your comments.

[codecov]

Codecov Report

Merging #1472 (4b1da32) into main (d8d0ee1) will decrease coverage by 0.03%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
- Coverage   79.32%   79.28%   -0.04%     
==========================================
  Files         162      162              
  Lines        8501     8516      +15     
==========================================
+ Hits         6743     6752       +9     
- Misses       1076     1081       +5     
- Partials      682      683       +1     

Impacted Files	Coverage Δ
pkg/kn/config/config.go	52.94% <14.28%> (-4.64%)	⬇️
pkg/errors/errors.go	100.00% <0.00%> (ø)
pkg/kn/commands/source/list_types.go	56.86% <0.00%> (ø)
pkg/kn/commands/channel/list_types.go	64.70% <0.00%> (ø)
...kg/kn/commands/service/configuration_edit_flags.go	80.47% <0.00%> (+0.23%)	⬆️
pkg/kn/flags/podspec.go	77.05% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d0ee1...4b1da32. Read the comment docs.

[boaz0]

Ummm... I think pull-knative-client-integration-tests failure isn't related to the change (I see timeout error).
Also, I ran coverage on my computer and from the go tool cover output I see that must of was covered so I have no idea why the codecov/patch gives me only 41.17% coverage 🤷‍♂️

[dsimansk]

Ummm... I think pull-knative-client-integration-tests failure isn't related to the change (I see timeout error). Also, I ran coverage on my computer and from the go tool cover output I see that must of was covered so I have no idea why the codecov/patch gives me only 41.17% coverage man_shrugging

The reported coverage is calculated by Codecov standards that doesn't match go tool numbers usually. If you navigate through Details you can see the annotated diff with missing coverage. Those annotations are also added to PR's diff view.

[dsimansk]

Per our chat with @boaz0 I've suggested the following approach to the config init:

• No new init/no-init flags (easy to add hard to remove later due to deprecation policy :))
• Create the file if not present
• populate the file with commented-out example config only
• Fail silently if there's write permission issue etc.

@maximilien @navidshaikh @rhuss @itsmurugappan please state any objections to the above.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/config/config.go	73.6%	72.3%	-1.3

[dsimansk]

/retest

[rhuss]

/retest

[rhuss]

/approve
/lgtm

Thanks !

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: boaz0, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment