Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tekton - use ClusterRoleBinding v1 #1440

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Tekton - use ClusterRoleBinding v1 #1440

merged 3 commits into from
Aug 30, 2021

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 30, 2021

Description

Make the tests compatible with Kube 1.22 which removes v1beta1

Changes

Reference

Fixes #

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 30, 2021
@mgencur mgencur changed the title Tekton - use ClusterRoleBinding v1 [WIP] Tekton - use ClusterRoleBinding v1 Aug 30, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021 •
edited
Loading

Codecov Report

Merging #1440 (d35c009) into main (c717a3f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage   78.70%   78.70%           
=======================================
  Files         162      162           
  Lines        8368     8368           
=======================================
  Hits         6586     6586           
  Misses       1098     1098           
  Partials      684      684

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c717a3f...d35c009. Read the comment docs.

@mgencur mgencur changed the title [WIP] Tekton - use ClusterRoleBinding v1 Tekton - use ClusterRoleBinding v1 Aug 30, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2021
@mgencur
Copy link
Contributor Author

mgencur commented Aug 30, 2021

The changes passed in runs:
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1440/pull-knative-client-integration-tests/1432320658838130688
https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1440/pull-knative-client-integration-tests-latest-release/1432320658905239552
Removed the temporary changes and it's ready for review.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@knative-prow-robot knative-prow-robot merged commit 7e90dca into knative:main Aug 30, 2021
mgencur added a commit to mgencur/knative-client that referenced this pull request Oct 4, 2021
@mgencur
Tekton - use ClusterRoleBinding v1 (knative#1440)
7d996d3 
* Tekton test - ClusterRoleBinding v1

* make it compatible with Kubernetes 1.22

* TMP: Test Tekton in presubmits

* Revert "TMP: Test Tekton in presubmits"

This reverts commit 8996ac7.
@mgencur mgencur mentioned this pull request Oct 4, 2021
Merged
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Oct 4, 2021
@mgencur
Tekton - use ClusterRoleBinding v1 (knative#1440) (#828)
b4fa2e8 
* Tekton test - ClusterRoleBinding v1

* make it compatible with Kubernetes 1.22

* TMP: Test Tekton in presubmits

* Revert "TMP: Test Tekton in presubmits"

This reverts commit 8996ac7.
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-client that referenced this pull request Oct 4, 2021
@mgencur
Tekton - use ClusterRoleBinding v1 (knative#1440)
cfa4241 
* Tekton test - ClusterRoleBinding v1

* make it compatible with Kubernetes 1.22

* TMP: Test Tekton in presubmits

* Revert "TMP: Test Tekton in presubmits"

This reverts commit 8996ac7.
openshift-merge-robot pushed a commit to openshift/knative-client that referenced this pull request Oct 4, 2021
@openshift-cherrypick-robot @mgencur
Tekton - use ClusterRoleBinding v1 (knative#1440) (#829)
18dd014 
* Tekton test - ClusterRoleBinding v1

* make it compatible with Kubernetes 1.22

* TMP: Test Tekton in presubmits

* Revert "TMP: Test Tekton in presubmits"

This reverts commit 8996ac7.

Co-authored-by: Martin Gencur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk approved these changes

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @knative-prow-robot @dsimansk