Add an update timestamp to trigger the creation of a revision when needed.

[rhuss]

Add an update timestamp anytime a new revision should be triggered. Previously client-side revision names were this trigger but since we switched to server-side revision naming by default that didn't work anymore (and hasn't worked with server-side revision naming before, too).

Fixes #1318.

/lint

[knative-prow-robot]

@rhuss: 3 warnings.

In response to this:

Add an update timestamp anytime a new revision should be triggered. Previously client-side revision names were this trigger but since we switched to server-side revision naming by default that didn't work anymore (and hasn't worked with server-side revision naming before, too).

Fixes #1318.

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Golint comments: exported var UserImageAnnotationKey should have comment or be unexported. More info.

[codecov]

Codecov Report

Merging #1364 (99661ff) into main (b05a111) will increase coverage by 0.09%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
+ Coverage   78.23%   78.33%   +0.09%     
==========================================
  Files         160      160              
  Lines        8246     8270      +24     
==========================================
+ Hits         6451     6478      +27     
+ Misses       1104     1103       -1     
+ Partials      691      689       -2     

Impacted Files	Coverage Δ
pkg/kn/plugin/manager.go	83.95% <ø> (ø)
pkg/kn/commands/revision/describe.go	50.61% <50.00%> (ø)
pkg/serving/config_changes.go	89.85% <72.00%> (+5.10%)	⬆️
pkg/serving/revision_template.go	90.90% <88.23%> (-3.04%)	⬇️
...kg/kn/commands/service/configuration_edit_flags.go	77.91% <100.00%> (+0.27%)	⬆️
pkg/kn/commands/service/export.go	81.48% <100.00%> (+0.46%)	⬆️
pkg/kn/commands/service/update.go	80.59% <100.00%> (+0.29%)	⬆️
pkg/serving/v1/client.go	82.85% <100.00%> (+0.99%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05a111...99661ff. Read the comment docs.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[rhuss]

/retest

[rhuss]

/retest

[rhuss]

@dsimansk PTAL, added some tests and addressed the error return value issue.

[dsimansk]

@rhuss looks good. However lint check isn't happy.

  Error: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)
  Error: SA5011: possible nil pointer dereference (staticcheck)
  Error: SA5011(related information): this check suggests that the pointer can be nil (staticcheck)

[rhuss]

@dsimansk thanks for the review. Really would love to catch those lint errors with our build script. Any idea ?

[dsimansk]

@dsimansk thanks for the review. Really would love to catch those lint errors with our build script. Any idea ?

Agreed, we should add it to the script. The initial run may take a bit longer ~20s, but then cache will speed subsequent runs up significantly. And it's a matter of executing:

golangci-lint run

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/service/configuration_edit_flags.go	85.0%	85.2%	0.2
pkg/kn/commands/service/export.go	87.6%	88.2%	0.6
pkg/kn/commands/service/update.go	86.7%	86.9%	0.2
pkg/serving/config_changes.go	92.1%	94.5%	2.5
pkg/serving/revision_template.go	97.0%	95.3%	-1.6
pkg/serving/v1/client.go	90.7%	91.0%	0.3

[dsimansk]

Thanks!

/approve
/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment