-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify printing of webhook warnings #1353
Prettify printing of webhook warnings #1353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusthoemmes: 0 warnings.
In response to this:
Description
Adds a proper warning printer to have warnings being printed in a similar format as "other messages". Color could be easily supported but it seemed like
kn
doesn't color in general. Let me know if that aint the case.Changes
Output before:
W0624 13:35:20.413073 372781 warnings.go:70] This is a test! Replacing service 'foo' in namespace 'default': ...
Output after:
Warning: This is a test! Replacing service 'foo' in namespace 'default': ...
Reference
Fixes #1350
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
30727b0
to
1b74cdd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1353 +/- ##
==========================================
- Coverage 72.96% 72.94% -0.03%
==========================================
Files 160 160
Lines 8083 8086 +3
==========================================
Hits 5898 5898
- Misses 1463 1466 +3
Partials 722 722
Continue to review full report at Codecov.
|
1b74cdd
to
b54c584
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
Looks good to me, but not sure how make codecov happy. I don't think codecov is a mandatory check, so lets try to merge it.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds a proper warning printer to have warnings being printed in a similar format as "other messages". Color could be easily supported but it seemed like
kn
doesn't color in general. Let me know if that aint the case.Changes
Output before:
Output after:
Reference
Fixes #1350