Make e2e test run over other networks

[BbolroC]

Description

The current e2e test only runs over the network istio. It would be good to run the test over other network layers (e.g. contour and kourier) if the network is pre-installed and the environment variable $INGRESS_CLASS is set.

Changes

• Introduce an environment $INGRESS_CLASS
• Toggle off the istio installation when the $INGRESS_CLASS is set to a value other than istio.ingress.networking.knative.dev (e.g. kourier or contour)
• Set the ingress.class against the config map config-network in the e2e test
• Assume that the corresponding network should be installed in advance

Reference

Fixes #1337

[knative-prow-robot]

Hi @BbolroC. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #1339 (b12b322) into main (81cb343) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1339   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files         160      160           
  Lines        8151     8151           
=======================================
  Hits         5948     5948           
  Misses       1476     1476           
  Partials      727      727           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81cb343...b12b322. Read the comment docs.

[navidshaikh]

/ok-to-test

/assign @dsimansk

[maximilien]

/ok-to-test

Can you mention the other networks you are testing?

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BbolroC, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BbolroC]

/ok-to-test

Can you mention the other networks you are testing?

I tested contour, but there should be no problem with kourier as well.