Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CRDs API version to v1 #1248

Merged
merged 3 commits into from
Mar 4, 2021
Merged

chore: Update CRDs API version to v1 #1248

merged 3 commits into from
Mar 4, 2021

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Mar 3, 2021

Description

The CRDs v1beta1 version is deprecated since K8s 1.16 and will be removed in 1.22. However, it may produce a warning on newer Kubernetes clusters already.

We should probably handle the warning as well and don't fail prematurely.

Changes

  • Update CRDs API version to v1

Reference

Fixes N/A

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 3, 2021
knative-prow-robot
knative-prow-robot reviewed Mar 3, 2021
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

The CRDs v1beta1 version is deprecated since K8s 1.16 and will be removed in 1.22. However, it may produce a warning on newer Kubernetes clusters already.

We should probably handle the warning as well and don't fail prematurely.

Changes

  • Update CRDs API version to v1

Reference

Fixes N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2021
maximilien
maximilien approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2021
rhuss
rhuss approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ffe385a into knative:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@rhuss rhuss rhuss approved these changes

@maximilien maximilien maximilien approved these changes

Assignees

@maximilien maximilien

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsimansk @knative-prow-robot @maximilien @rhuss