Adds a Golang version of e2e Basic workflow that can execute locally #121

maximilien · 2019-05-17T00:02:32Z

creates a namespace ‘kne2etests’ (default name, change setting env in test/e2e-tests-local.sh)
executes kn commands as per Basic workflow doc (in namespace)
verifies each command output
deletes the kne2etests namespace

Finishes #114 for Basic workflow

test/e2e-tests-local.sh

knative-metrics-robot · 2019-05-17T00:20:40Z

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
test/e2e/e2e.go	Do not exist	33.3%
test/e2e/env.go	Do not exist	87.5%
test/e2e/kn.go	Do not exist	64.0%
test/e2e/kubectl.go	Do not exist	68.2%

test/e2e/basic_workflow_test.go

test/e2e/kubectl.go

adrcunha · 2019-05-17T00:54:39Z

Now just replace that call to kn in e2e-tests.sh and your new Go tests will run against the test cluster and report correctly in Gubernator and TestGrid:

go_test_e2e ./test/e2e

test/e2e-tests.sh

adrcunha · 2019-05-17T02:31:50Z

/lint

knative-prow-robot

@adrcunha: 16 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/e2e/kubectl.go

test/e2e/basic_workflow_test.go

test/e2e/common.go

test/e2e/env.go

test/e2e/kn.go

maximilien · 2019-05-17T05:04:08Z

/lint

knative-prow-robot

@maximilien: 2 unresolved warnings and 2 new warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/e2e/e2e.go

test/e2e/env.go

maximilien · 2019-05-17T07:02:06Z

/lint

knative-prow-robot

@maximilien: 1 unresolved warnings and 3 new warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/e2e/e2e.go

test/e2e/env.go

maximilien · 2019-05-17T07:04:59Z

/lint

knative-prow-robot

@maximilien: 3 unresolved warnings and 0 new warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maximilien · 2019-05-17T07:08:54Z

/lint

knative-prow-robot

@maximilien: 1 unresolved warning and 0 new warning.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maximilien · 2019-05-17T07:12:43Z

/lint

I have to figure out how to run this locally :(

knative-prow-robot

@maximilien: 0 warnings.

In response to this:

/lint

I have to figure out how to run this locally :(

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maximilien · 2019-05-17T12:52:20Z

/retest

maximilien · 2019-06-07T19:57:50Z

/retest

Seems like the built kn is not accessible. Let me add . to the path since current test/e2e-tests.sh refers to the kn executable with ./kn ...

maximilien · 2019-06-07T21:01:27Z

@sixolet seems like success finally!

adrcunha · 2019-06-07T21:06:38Z

test/e2e-tests.sh

+
+dir=$(dirname "${BASH_SOURCE[0]}")
+base=$(cd "$dir/.." && pwd)
+export PATH=$PATH:$base


Just do

export PATH=$PATH:${REPO_ROOT_DIR}

test/e2e-tests.sh

1. creates a namespace 'kne2etests' (default name, change with env KN_E2E_NAMESPACE) 2. executes kn commands as per Basic workflow doc in said namespace 3. verifies each command's output 4. deletes the 'kne2etests' namespace

rhuss · 2019-06-11T17:21:55Z

Because I stumbled upon in https://github.com/docker/cli/blob/master/e2e/container/kill_test.go, @maximilien have you considered https://github.com/gotestyourself/gotest.tools which seems to have nice support for executing external commands.

maximilien · 2019-06-11T17:26:55Z

Because I stumbled upon in https://github.com/docker/cli/blob/master/e2e/container/kill_test.go, @maximilien have you considered https://github.com/gotestyourself/gotest.tools which seems to have nice support for executing external commands.

No, I have not. Will take a look. I however, want to address what's holding this PR to being merged and then do any refactoring in future. I believe last feedback is from @cppforlife on unnecessary imports that ./test/presubmit-tests.sh introduced. A problem I thought was fixed. But will attempt to remove the imports, though I believe CI will fail... Anyhow, I will confirm here.

maximilien · 2019-06-11T18:20:00Z

gotest.tools on first glance looks pretty cool @rhuss. I can see some aspect I could use immediately, e.g., the fake FS and env. But it can definitely be added after. So perhaps as I submit future PR I will try to add this to any integration tests and give it a test drive.

cc: @cppforlife since the Fake FS brought back some BOSH utils FakeFS memories :)

maximilien · 2019-06-11T20:36:00Z

/test pull-knative-client-integration-tests

maximilien · 2019-06-11T20:55:16Z

@sixolet @cppforlife this is ready to merge. I will create following issues to look into any refactoring that is needed. I need this to merge to add more integration tests as I prepare to submit first PR on plugins. Let me know your thoughts if not ready for /lgtm label. Thx.

sixolet · 2019-06-12T02:48:47Z

/lgtm
/approve

knative-prow-robot · 2019-06-12T02:48:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sixolet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…native#121) 1. creates a namespace 'kne2etests' (default name, change with env KN_E2E_NAMESPACE) 2. executes kn commands as per Basic workflow doc in said namespace 3. verifies each command's output 4. deletes the 'kne2etests' namespace

Implements Kn plugins re-using some code from kubectl plugins. This is WIP to allow concrete discussions and testing and hopefully also allow sub tasks to be created and worked on in parallel. This version contains the following: 1. wraps the main root Kn command to support plugin 2. plugins are any executable in PATH with name kn-* 3. 'kn plugins list' to list found kn plugins 4. skips any kn plugins found with name that match core commands, e.g., kn-service would be ignored 5. execute any valid kn plugins found And is missing: 1. unit and integration tests 2. plugin install command 3. plugin repository command 4. plugin / Knative server version negotiation 5. anything else we agree on in plugin req doc Adds a Golang version of e2e Basic workflow that can execute locally (knative#121) 1. creates a namespace 'kne2etests' (default name, change with env KN_E2E_NAMESPACE) 2. executes kn commands as per Basic workflow doc in said namespace 3. verifies each command's output 4. deletes the 'kne2etests' namespace Fix typo in README.md (knative#181) Renames service 'get' to 'list' (knative#179) * Renames service 'get' to 'list' As per title. * Renames get references to list in e2e tests * Replaces get to list in docs Renames revision 'get' to 'list' (knative#180) * Renames revision 'get' to 'list' As per title. * Renames revision get references to revision list in docs feat(build.sh) - Add mandatory license check (knative#187) We could decide to make that optional, too, if this is coming into the way. Chore: Fix typos in docs (knative#178) fix(service update): Print success message after successful update (knative#169) * fix(service update): Print success message after successful update * chore(service update): Improve test, revert unneeded changes [WIP] Kn plugins implementation Implements Kn plugins re-using some code from kubectl plugins. This is WIP to allow concrete discussions and testing and hopefully also allow sub tasks to be created and worked on in parallel. This version contains the following: 1. wraps the main root Kn command to support plugin 2. plugins are any executable in PATH with name kn-* 3. 'kn plugins list' to list found kn plugins 4. skips any kn plugins found with name that match core commands, e.g., kn-service would be ignored 5. execute any valid kn plugins found 6. started adding UTs for plugin commands and files 7. rebased with latest HEAD And is missing: 1. integration tests 2. plugin install command 3. plugin repository command 4. plugin / Knative server version negotiation 5. anything else we agree on in plugin req doc

Implements Kn plugins re-using some code from kubectl plugins. This is WIP to allow concrete discussions and testing and hopefully also allow sub tasks to be created and worked on in parallel. This version contains the following: 1. wraps the main root Kn command to support plugin 2. plugins are any executable in PATH with name kn-* 3. 'kn plugins list' to list found kn plugins 4. skips any kn plugins found with name that match core commands, e.g., kn-service would be ignored 5. execute any valid kn plugins found 6. UTs for plugin and plugin list commands And is missing: 1. integration tests 2. plugin install command 3. plugin repository command 4. plugin / Knative server version negotiation 5. anything else we agree on in plugin req doc Adds a Golang version of e2e Basic workflow that can execute locally (knative#121) 1. creates a namespace 'kne2etests' (default name, change with env KN_E2E_NAMESPACE) 2. executes kn commands as per Basic workflow doc in said namespace 3. verifies each command's output 4. deletes the 'kne2etests' namespace

knative-prow-robot requested review from cppforlife and evankanderson May 17, 2019 00:02

knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2019

adrcunha reviewed May 17, 2019

View reviewed changes

test/e2e-tests-local.sh Show resolved Hide resolved

test/e2e-tests-local.sh Outdated Show resolved Hide resolved

maximilien force-pushed the e2e-local-tests branch from 1b68c76 to 7f7ca03 Compare May 17, 2019 00:19

adrcunha reviewed May 17, 2019

View reviewed changes

test/e2e/basic_workflow_test.go Outdated Show resolved Hide resolved

test/e2e/kubectl.go Outdated Show resolved Hide resolved

maximilien force-pushed the e2e-local-tests branch from 7f7ca03 to fcfedb5 Compare May 17, 2019 01:17

adrcunha reviewed May 17, 2019

View reviewed changes

test/e2e-tests.sh Outdated Show resolved Hide resolved