Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling in clients #1154

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Improve error handling in clients #1154

merged 1 commit into from
Nov 30, 2020

Conversation

arghya88
Copy link
Contributor

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

Improve error handling in clients to capture server side errors

Reference

Fixes #

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 28, 2020
knative-prow-robot
knative-prow-robot reviewed Nov 28, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arghya88: 0 warnings.

In response to this:

Signed-off-by: Arghya Sadhu [email protected]

Description

Changes

Improve error handling in clients to capture server side errors

Reference

Fixes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2020
@arghya88 arghya88 force-pushed the improve-error-handling branch from 25f8002 to fa89b70 Compare November 28, 2020 07:40
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/sources/v1alpha2/apiserver_client.go 89.7% 90.0% 0.3
pkg/sources/v1alpha2/ping_client.go 88.5% 89.8% 1.4

@navidshaikh navidshaikh added this to the v0.20.0 milestone Nov 30, 2020
navidshaikh
navidshaikh approved these changes Nov 30, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @arghya88 for taking care of this!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghya88, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@knative-prow-robot knative-prow-robot merged commit 1a57fd8 into knative:master Nov 30, 2020
@arghya88 arghya88 deleted the improve-error-handling branch November 30, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arghya88 @knative-metrics-robot @knative-prow-robot @navidshaikh