-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aliases to Help Command and Remove Aliases in Short #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielhelfand: 0 warnings.
In response to this:
Description
This pull request makes changes for when using help to see more information about a command:
- Adds aliases to the help command output
- Reorders the help command output so that usage and aliases are displayed before examples and options
- Removes aliases from the short description of commands
These changes will help to make maintaining documentation around aliases easier so that the short descriptions of commands don't need to be updated each time with the addition or removal of aliases.
The reordering of the help section was discussed in the corresponding issue.
Reference
Fixes # 1045
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi @danielhelfand. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
I will review once I can see tests results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, maximilien, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This pull request makes changes for when using help to see more information about a command:
These changes will help to make maintaining documentation around aliases easier so that the short descriptions of commands don't need to be updated each time with the addition or removal of aliases.
The reordering of the help section was discussed in the corresponding issue.
Reference
Fixes #1045
/lint