-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithLabel list filter to serving client lib #1054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zroubalik: 1 warning.
In response to this:
Signed-off-by: Zbynek Roubalik [email protected]
Description
Adding
WithLabel
list filter to serving client lib, which is missing currently. This allows to filter lists by labels.Reference
Fixes #1053
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Welcome @zroubalik! It looks like this is your first PR to knative/client 🎉 |
Hi @zroubalik. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Looks good, but could you please also add a test to client_test_mock.go and client_test.go ?
Also an entry in CHANGELOG.adoc would be cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributions. Any way to add tests and show how to use this?
I have added tests. Let me know if I should add anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @zroubalik ! can you please finalize the PR with a changelog entry in CHANGELOG.adoc ?
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
@navidshaikh Changelog updated, let me know if you need anything else, thanks! |
The following is the coverage report on the affected files.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks @zroubalik for contribution, keep them coming! ;-)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navidshaikh, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add WithLabel list filter Signed-off-by: Zbynek Roubalik <[email protected]> * adding tests Signed-off-by: Zbynek Roubalik <[email protected]> * update changelog Signed-off-by: Zbynek Roubalik <[email protected]>
* add WithLabel list filter Signed-off-by: Zbynek Roubalik <[email protected]> * adding tests Signed-off-by: Zbynek Roubalik <[email protected]> * update changelog Signed-off-by: Zbynek Roubalik <[email protected]>
* Fix for test flake when sync waiting and an intermediate error occurs (#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added * Add WithLabel list filter to serving client lib (#1054) * add WithLabel list filter Signed-off-by: Zbynek Roubalik <[email protected]> * adding tests Signed-off-by: Zbynek Roubalik <[email protected]> * update changelog Signed-off-by: Zbynek Roubalik <[email protected]> * Update CHANGELOG Co-authored-by: Roland Huß <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
* Fix for test flake when sync waiting and an intermediate error occurs (#1052) * fix: Cancel error timer on sync wait when a non-error event arrives * chore: Added * Add WithLabel list filter to serving client lib (#1054) * add WithLabel list filter Signed-off-by: Zbynek Roubalik <[email protected]> * adding tests Signed-off-by: Zbynek Roubalik <[email protected]> * update changelog Signed-off-by: Zbynek Roubalik <[email protected]> * Update CHANGELOG Co-authored-by: Roland Huß <[email protected]> Co-authored-by: Zbynek Roubalik <[email protected]>
* add WithLabel list filter Signed-off-by: Zbynek Roubalik <[email protected]> * adding tests Signed-off-by: Zbynek Roubalik <[email protected]> * update changelog Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Zbynek Roubalik [email protected]
Description
Adding
WithLabel
list filter to serving client lib, which is missing currently. This allows to filter lists by labels.Reference
Fixes #1053
/lint