Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check DeleteTimestamp before creating/modifying resource #786

Closed
sixolet opened this issue Apr 7, 2020 · 1 comment · Fixed by #805
Closed

Check DeleteTimestamp before creating/modifying resource #786

sixolet opened this issue Apr 7, 2020 · 1 comment · Fixed by #805
Labels
good first issue Denotes an issue ready for a new contributor. kind/bug Categorizes issue or PR as related to a bug.

Comments

@sixolet
Copy link
Contributor

sixolet commented Apr 7, 2020

Bug report

We currently don't check if metadata.deleteTimestamp is set before modifying a resource.

Expected behavior

Give the user an error if metadata.deleteTimestamp is set; the resource is in the process of a foreground deletion.

Steps to reproduce the problem

Delete and then immediately modify a service
@sixolet sixolet added kind/bug Categorizes issue or PR as related to a bug. good first issue Denotes an issue ready for a new contributor. labels Apr 7, 2020
@MIBc
Copy link
Contributor

MIBc commented Apr 8, 2020

I want to try.

@MIBc MIBc mentioned this issue Apr 15, 2020
Merged
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Create the automated release jobs for Knative Client (knative#786)
627c85f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check DeleteTimestamp before updating resource MIBc/client
2 participants
@sixolet @MIBc