Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Installing the Knative CLI" on knative.dev & in README #648

Closed
rhuss opened this issue Feb 11, 2020 · 8 comments
Closed

Update "Installing the Knative CLI" on knative.dev & in README #648

rhuss opened this issue Feb 11, 2020 · 8 comments
Assignees
Labels
kind/doc Issues and pull requests for documentations kind/feature New feature or request

Comments

@rhuss
Copy link
Contributor

rhuss commented Feb 11, 2020

In what area(s)?

Describe the feature:

The [kn installation instruction] for the kn client is outdated and not well formatted:

  • Missing introduction where to download released versions
  • Describe how to make it executable and put it into the path
  • Missing link to release notes
  • Missing instruction how to run kn from Docker images (including volume mount to mount ~/.kubec/config)
  • Prerequisites for installing via go (i.e. Go 1.13)
  • Should be included in the GitHub README of the client, too.
  • Add a sample command (kn version) to verify whether kn is working properly

This story is part of #510 .

@rhuss rhuss added the kind/feature New feature or request label Feb 11, 2020
@knative-prow-robot knative-prow-robot added the kind/doc Issues and pull requests for documentations label Feb 11, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Feb 11, 2020

The fiel to be updated is over there in the docs repo (where also the PR needs to be raised): https://github.com/knative/docs/blob/master/docs/install/install-kn.md

@MIBc
Copy link
Contributor

MIBc commented Feb 16, 2020

I can have a try.

@rhuss
Copy link
Contributor Author

rhuss commented Feb 16, 2020

Cool, thanks ! Actually it would be best to start over there at docs, to improve the installation documentation. Also, please track #400 as we are about to enable a brew based installation.

The README rework is long overdue and is the next on my task list. As soon as I'm there we should update the instructions here, too.

/assign MiBc

@kristianmandrup
Copy link

I've been unable to install the client on my MacOSX. Have been trying many different approaches as outlined in 315

Hope you will soon have the brew based solution available. Cheers!

@rhuss
Copy link
Contributor Author

rhuss commented Feb 20, 2020

@kristianmandrup what are the concrete issue, maybe we can fix it quickly. You can download the latest macOS client from https://github.com/knative/client/releases/download/v0.12.0/kn-darwin-amd64 . Then I'd recommend:

$ mv kn-darwin-amd64 kn
$ chmod a+x kn
$ ./kn version

If you a permission (or not-signer-error) because you are running on Mojave, then you can do the following:

  • Open in Finder the directory with the downloaded binary
  • Right-click on the binary and Choose "Open".
  • You get a warning, but you should accept to run the binary.
  • This will flicker shortly in a window and then close.

After that, you can run the binary directly from the terminal as usual.
Apologies for this we are still on sorting out how to best sign the binary so that we don't need that workaround anymore.

@kristianmandrup
Copy link

Great. I have not seen these instruction on the install page of the Knative docs site.
Worked like a charm. When I tried this before, I had only used +x for chmod

kn version
Version:      v0.12.0
Build Date:   2020-01-29 21:03:45
Git Revision: 164cb5f
Supported APIs:
* Serving
  - serving.knative.dev/v1alpha1 (knative-serving v0.12.0)
* Eventing
  - sources.eventing.knative.dev/v1alpha1 (knative-eventing v0.12.0)
  - eventing.knative.dev/v1alpha1 (knative-eventing v0.12.0)
➜  Downloads kn service list
No services found.

@rhuss
Copy link
Contributor Author

rhuss commented Feb 20, 2020

Sorry for that. We are currently are on it (e.g. this issue ;-)

@rhuss
Copy link
Contributor Author

rhuss commented Sep 11, 2020

fixed with knative/docs#2230

Maybe we can move that installation section to the user guide sugested in #650

@rhuss rhuss closed this as completed Sep 11, 2020
dsimansk added a commit to dsimansk/client that referenced this issue Mar 31, 2021
* WIP: Add latest func plugin

* Update vendor dir

* Update func to v0.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/doc Issues and pull requests for documentations kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants