Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service describe: Move 'Cluster' URL to --verbose from default output #482

Closed
navidshaikh opened this issue Nov 6, 2019 · 0 comments · Fixed by #543
Closed

service describe: Move 'Cluster' URL to --verbose from default output #482

navidshaikh opened this issue Nov 6, 2019 · 0 comments · Fixed by #543
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request

Comments

@navidshaikh
Copy link
Collaborator

Quoting @rhuss #460 (comment)

In a followup PR I would suggest hiding the cluster URL behind --verbose as this is really only of interest in very rare circumstances (e.g. when used as a Destination in Eventing)
@navidshaikh navidshaikh added the kind/feature New feature or request label Nov 6, 2019
@navidshaikh navidshaikh mentioned this issue Nov 6, 2019
Merged
@navidshaikh navidshaikh added the good first issue Denotes an issue ready for a new contributor. label Nov 21, 2019
@itsmurugappan itsmurugappan mentioned this issue Dec 10, 2019
Merged
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Initial version of the Prow config generator (knative#482)
d1a1ffd 
* Initial version of the Prow config generator

`make_config.go` generates `config.yaml` based on a much smaller and simpler config `config_knative.yaml`.

This initial version makes some concessions regarding the output generation in order to produce a predictable, trackable config file, which can be easily compared to the current version.

* Ensure generator does generate the current config.yaml

* Fix comments
navidshaikh pushed a commit to navidshaikh/client that referenced this issue Oct 12, 2020
@dsimansk
Update SPEC file for release v0.17.1 (knative#482)
1f93635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

service describe command : Move Cluster URL to --verbose from default output
1 participant
@navidshaikh