-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kn source list - list all source instances (built-in, plugin, untyped) #480
Comments
rhuss
changed the title
kn source list
kn source list - List all typed and untyped source instances
Nov 27, 2019
Updated description with the content of the spec (which remains the authorative document) |
rhuss
changed the title
kn source list - List all typed and untyped source instances
kn source list - List all source instances (built-in, plugin, untyped)
Nov 27, 2019
rhuss
changed the title
kn source list - List all source instances (built-in, plugin, untyped)
kn source list - list all source instances (built-in, plugin, untyped)
Nov 27, 2019
We have leaf @maximilien are you on it? |
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 14, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 14, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 18, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 18, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 18, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 18, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 18, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry
navidshaikh
added a commit
to navidshaikh/client
that referenced
this issue
Feb 26, 2020
Fixes knative#480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry
knative-prow-robot
pushed a commit
that referenced
this issue
Mar 10, 2020
* feat(source): Add 'kn source list' Fixes #480 - Add 'kn source list' listing the available sources COs - Use dynamic client to - find out available source types - find the COs in given namespace for each source type - Add --type flag to filter source list based on source type - Add unit tests - Add e2e tests - Add CHANGELOG entry * Update group for ApiServerSource in tests * Add kn duck source type for holding common eventing source fileds - Common infromation from sources are extracted into a struct for source list command output - Printer function picks the information from this struct object and doesn't know the details about extracting this info from multiple types of sources received - Group and Version for list is set to empty string and Kind to 'List', if printed a source list with multiple types of sources in machine readable format - Group, Version and Kind for list are kept intact if printed a source list with same type of source objects in machine readable format * Update go.sum * Add WithType builder for listing source - Separate the flags definition - WithType builder can be re-used to filter the source types - Add unit tests * Update ApiServer source group to apiserversources.sources.knative.dev * Fix typos and align Co-authored-by: Roland Huß <[email protected]>
coryrc
pushed a commit
to coryrc/client
that referenced
this issue
May 14, 2020
APICoverage-Recorder in the commit knative/test-infra#463 was writting an instance of v1beta1.AdmissionResponse to the http.ResponseWriter when it should be writting v1beta1.AdmissionReview this changeset fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kn source list should list sources of all source CRDs, unlike the normal list which only lists one type. It should have an option to list only one type, too.
See the spec for details:
For listing all sources, kn queries all instances of source CRDs. So it first picks up all CRDs that are describing Sources and then queries each CRD type in turn to look up its COs and also checks whether this CO is supported by a typed source handler (built-in/plugin).
This list can be filtered by type (--type) or on the resource name (--source-name).
The general algorithm described above in pseudo-code:
The text was updated successfully, but these errors were encountered: