Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting multiple NAMEs on some commands #317

Closed
duglin opened this issue Jul 30, 2019 · 14 comments · Fixed by #1217
Closed

Consider supporting multiple NAMEs on some commands #317

duglin opened this issue Jul 30, 2019 · 14 comments · Fixed by #1217
Assignees
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.

Comments

@duglin
Copy link
Contributor

duglin commented Jul 30, 2019

In what area(s)?

Classifications:
/kind feature
/kind proposal

Describe the feature:

It would be nice if some commands supported multiple resource names to make life easier for people. For example, I was cleaning up my env and I tried this:

$ kn service delete echo helloworld foo
requires the service name.

and it died because it wasn't expecting more than one service name. It would be nice if we could support multiple NAMEs on certain commands where it makes sense.

It's also kind of an odd error message right now. I would have expected something more like only one service name is allowed, not a message implying I didn't specify any at all.

@duglin duglin added the kind/feature New feature or request label Jul 30, 2019
@knative-prow-robot knative-prow-robot added the kind/proposal Issues or PRs related to proposals. label Jul 30, 2019
@navidshaikh
Copy link
Collaborator

This is needed, I have to clean my dev environment, it needed multiple kn service delete commands.

I think we should implement this for kn service delete as well as kn revision delete
along with say --all option to delete all the services or revisions in current namespace.

It's also kind of an odd error message right now. I would have expected something more like only one service name is allowed, not a message implying I didn't specify any at all.

This is bug.

@daisy-ycguo
Copy link
Member

daisy-ycguo commented Nov 11, 2019

/assign

@wslyln
Copy link
Contributor

wslyln commented Feb 8, 2020

@daisy-ycguo just wanted to double check you're not working on multiple names on revision delete

I'd be up to work on it revision delete and trigger delete.

I checked the rest of the commands in kn and it doesn't seem like there are any others that multiple arguments really make sense. (I guess there might be a case of updating multiple services at a time, though it'd be pretty tricky)

@wslyln
Copy link
Contributor

wslyln commented Feb 12, 2020

/assign

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@duglin
Copy link
Contributor Author

duglin commented Oct 15, 2020

/remove-lifecycle stale
@daisy-ycguo @wslyln were one of you going to work on this?

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2021
@navidshaikh
Copy link
Collaborator

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2021
@navidshaikh navidshaikh added the good first issue Denotes an issue ready for a new contributor. label Jan 14, 2021
@Kaustubh-pande
Copy link
Contributor

I'd like to work on this issue.
/assign

@duglin
Copy link
Contributor Author

duglin commented Mar 15, 2021

/reopen

@knative-prow-robot
Copy link
Contributor

@duglin: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duglin
Copy link
Contributor Author

duglin commented Mar 15, 2021

#1217 doesn't actually address this (at least I don't think it does)

@duglin
Copy link
Contributor Author

duglin commented Mar 15, 2021

I missed that this was done before #1217 at least for delete
/close

@knative-prow-robot
Copy link
Contributor

@duglin: Closing this issue.

In response to this:

I missed that this was done before #1217 at least for delete
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request kind/proposal Issues or PRs related to proposals.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants