Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No domain/address for kn service list shown for serving 0.7.0 #246

Closed
rhuss opened this issue Jul 8, 2019 · 0 comments · Fixed by #247
Closed

No domain/address for kn service list shown for serving 0.7.0 #246

rhuss opened this issue Jul 8, 2019 · 0 comments · Fixed by #247
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Jul 8, 2019

The reason is that the old, deprecated DOMAIN field is not populated anymore. One should pick up the status.address.url field instead.

Also, the column "DOMAIN" should be renamed to "ADDRESS".

@rhuss rhuss self-assigned this Jul 8, 2019
@rhuss rhuss added this to the v0.2.0 milestone Jul 8, 2019
@rhuss rhuss added the kind/bug Categorizes issue or PR as related to a bug. label Jul 8, 2019
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 8, 2019
…g service

Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.

This fix should work with 0.6.0, too as the new fields already have been populated back then.

So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.

Fixes knative#246.
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 9, 2019
…g service

Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.

This fix should work with 0.6.0, too as the new fields already have been populated back then.

So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.

Fixes knative#246.
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 10, 2019
…g service

Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.

This fix should work with 0.6.0, too as the new fields already have been populated back then.

So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.

Fixes knative#246.
rhuss added a commit to rhuss/knative-client that referenced this issue Jul 10, 2019
…g service

Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.

This fix should work with 0.6.0, too as the new fields already have been populated back then.

So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.

Fixes knative#246.
knative-prow-robot pushed a commit that referenced this issue Jul 10, 2019
…listing service (#247)

* fix(service): Pick up new field Address instead of Domain when listing service

Starting with 0.7.0 old fields are not populated anymore. Let's switch to the new fields then.

This fix should work with 0.6.0, too as the new fields already have been populated back then.

So we can unconditionally pick status.address.url which is accordance with
our policy to support the latest release and the release before.

Fixes #246.

* fix(service list): Use status.URL instead of status.Address in column

* chore: Rebase and update changelog

* chore: Rebase and test fix
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
* only tag images from the current project
* don't use a git tag when tagging nightly images
dsimansk pushed a commit to dsimansk/client that referenced this issue Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
1 participant